Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1410343014: Remove unused crypto.gni import. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, Dirk Pranke
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused crypto.gni import. We are trying to move crypto.gni out of build/config in chromium, this should help with this work. BUG=None R=kjellander@webrtc.org Committed: https://crrev.com/444237e2e4adac32b6db22efe4d76ae3155e663f Cr-Commit-Position: refs/heads/master@{#10514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
tfarina
PTAL!
5 years, 1 month ago (2015-11-04 21:11:28 UTC) #1
kjellander_chromium
lgtm
5 years, 1 month ago (2015-11-04 21:18:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343014/1
5 years, 1 month ago (2015-11-04 21:50:24 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-04 21:50:26 UTC) #7
kjellander_webrtc
lgtm Sorry, wrong account. Will send it to CQ now. lgtm
5 years, 1 month ago (2015-11-04 22:42:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343014/1
5 years, 1 month ago (2015-11-04 22:42:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 22:44:01 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 22:44:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/444237e2e4adac32b6db22efe4d76ae3155e663f
Cr-Commit-Position: refs/heads/master@{#10514}

Powered by Google App Engine
This is Rietveld 408576698