Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: webrtc/video/video_quality_test.cc

Issue 1409993011: Add screenshare perf tests with lossy links (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/full_stack.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <stdio.h> 10 #include <stdio.h>
(...skipping 623 matching lines...) Expand 10 before | Expand all | Expand 10 after
634 params_.ss.streams.push_back(VideoQualityTest::DefaultVideoStream(params_)); 634 params_.ss.streams.push_back(VideoQualityTest::DefaultVideoStream(params_));
635 if (params_.ss.num_spatial_layers == 0) 635 if (params_.ss.num_spatial_layers == 0)
636 params_.ss.num_spatial_layers = 1; 636 params_.ss.num_spatial_layers = 1;
637 637
638 if (params_.pipe.loss_percent != 0 || 638 if (params_.pipe.loss_percent != 0 ||
639 params_.pipe.queue_length_packets != 0) { 639 params_.pipe.queue_length_packets != 0) {
640 // Since LayerFilteringTransport changes the sequence numbers, we can't 640 // Since LayerFilteringTransport changes the sequence numbers, we can't
641 // use that feature with pack loss, since the NACK request would end up 641 // use that feature with pack loss, since the NACK request would end up
642 // retransmitting the wrong packets. 642 // retransmitting the wrong packets.
643 RTC_CHECK(params_.ss.selected_sl == -1 || 643 RTC_CHECK(params_.ss.selected_sl == -1 ||
644 params_.ss.num_spatial_layers == 1); 644 params_.ss.selected_sl == params_.ss.num_spatial_layers - 1);
645 RTC_CHECK(params_.common.selected_tl == -1 || 645 RTC_CHECK(params_.common.selected_tl == -1 ||
646 params_.common.num_temporal_layers == 1); 646 params_.common.selected_tl ==
647 params_.common.num_temporal_layers - 1);
647 } 648 }
648 649
649 // TODO(ivica): Should max_bitrate_bps == -1 represent inf max bitrate, as it 650 // TODO(ivica): Should max_bitrate_bps == -1 represent inf max bitrate, as it
650 // does in some parts of the code? 651 // does in some parts of the code?
651 RTC_CHECK_GE(params_.common.max_bitrate_bps, 652 RTC_CHECK_GE(params_.common.max_bitrate_bps,
652 params_.common.target_bitrate_bps); 653 params_.common.target_bitrate_bps);
653 RTC_CHECK_GE(params_.common.target_bitrate_bps, 654 RTC_CHECK_GE(params_.common.target_bitrate_bps,
654 params_.common.min_bitrate_bps); 655 params_.common.min_bitrate_bps);
655 RTC_CHECK_LT(params_.common.selected_tl, params_.common.num_temporal_layers); 656 RTC_CHECK_LT(params_.common.selected_tl, params_.common.num_temporal_layers);
656 RTC_CHECK_LT(params_.ss.selected_stream, params_.ss.streams.size()); 657 RTC_CHECK_LT(params_.ss.selected_stream, params_.ss.streams.size());
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
1064 send_stream_->Stop(); 1065 send_stream_->Stop();
1065 receive_stream->Stop(); 1066 receive_stream->Stop();
1066 1067
1067 call->DestroyVideoReceiveStream(receive_stream); 1068 call->DestroyVideoReceiveStream(receive_stream);
1068 call->DestroyVideoSendStream(send_stream_); 1069 call->DestroyVideoSendStream(send_stream_);
1069 1070
1070 transport.StopSending(); 1071 transport.StopSending();
1071 } 1072 }
1072 1073
1073 } // namespace webrtc 1074 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/video/full_stack.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698