Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1409993011: Add screenshare perf tests with lossy links (Closed)

Created:
5 years, 1 month ago by sprang_webrtc
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add screenshare perf tests with lossy links This is a re-land of https://codereview.webrtc.org/1409513005/ Fingers crossed, the problems previously seen have been resolved by https://codereview.webrtc.org/1412233003/ BUG= Committed: https://crrev.com/ee37de3c13c5fe4b397d909918e9f980dc8184c5 Cr-Commit-Position: refs/heads/master@{#10751}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M webrtc/video/full_stack.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sprang_webrtc
5 years, 1 month ago (2015-11-12 15:36:09 UTC) #2
pbos-webrtc
here's hoping! lgtm
5 years, 1 month ago (2015-11-12 15:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409993011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409993011/1
5 years, 1 month ago (2015-11-16 09:51:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/3304) ios_dbg on tryserver.webrtc (JOB_FAILED, ...
5 years, 1 month ago (2015-11-16 09:52:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409993011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409993011/20001
5 years, 1 month ago (2015-11-23 13:16:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 14:10:27 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 14:10:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee37de3c13c5fe4b397d909918e9f980dc8184c5
Cr-Commit-Position: refs/heads/master@{#10751}

Powered by Google App Engine
This is Rietveld 408576698