webrtc/modules/video_coding/main/source/jitter_buffer.cc - Issue 1409753007: Reland of "Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/main/source/jitter_buffer.cc

Issue 1409753007: Reland of "Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: also update include/module_common_types.h Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc ('k') | webrtc/modules/video_coding/main/source/session_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/main/source/jitter_buffer.cc

diff --git a/webrtc/modules/video_coding/main/source/jitter_buffer.cc b/webrtc/modules/video_coding/main/source/jitter_buffer.cc

index 5385e0f855cefb947642d6dfd4e237d48edf7df6..a5e774b0153d750bedbf194b058af307a37ae49e 100644

--- a/webrtc/modules/video_coding/main/source/jitter_buffer.cc

+++ b/webrtc/modules/video_coding/main/source/jitter_buffer.cc

@@ -168,6 +168,7 @@ void Vp9SsMap::AdvanceFront(uint32_t timestamp) {

ss_map_[timestamp] = gof;

}

+// TODO(asapersson): Update according to updates in RTP payload profile.

bool Vp9SsMap::UpdatePacket(VCMPacket* packet) {

uint8_t gof_idx = packet->codecSpecificHeader.codecHeader.VP9.gof_idx;

if (gof_idx == kNoGofIdx)

@@ -186,7 +187,7 @@ bool Vp9SsMap::UpdatePacket(VCMPacket* packet) {

// TODO(asapersson): Set vp9.ref_picture_id[i] and add usage.

vp9->num_ref_pics = it->second.num_ref_pics[gof_idx];

- for (size_t i = 0; i < it->second.num_ref_pics[gof_idx]; ++i) {

+ for (uint8_t i = 0; i < it->second.num_ref_pics[gof_idx]; ++i) {

vp9->pid_diff[i] = it->second.pid_diff[gof_idx][i];

}

return true;