Reland of "Change type of pid_diff (int16_t -> uint8_t) according to updates in RTP payload profile…

webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 221 matching lines @@
 // P,F: | P_DIFF      |N|  up to 3 times          has to be specified.
 //      +-+-+-+-+-+-+-+-+                    N=1: An additional P_DIFF follows
 //                                                current P_DIFF.
 //
 bool WriteRefIndices(const RTPVideoHeaderVP9& vp9,
                      rtc::BitBufferWriter* writer) {
   if (!PictureIdPresent(vp9) ||
       vp9.num_ref_pics == 0 || vp9.num_ref_pics > kMaxVp9RefPics) {
     return false;
   }
-  for (size_t i = 0; i < vp9.num_ref_pics; ++i) {
+  for (uint8_t i = 0; i < vp9.num_ref_pics; ++i) {
     bool n_bit = !(i == vp9.num_ref_pics - 1);
     RETURN_FALSE_ON_ERROR(writer->WriteBits(vp9.pid_diff[i], 7));
     RETURN_FALSE_ON_ERROR(writer->WriteBits(n_bit ? 1 : 0, 1));
   }
   return true;
 }
 
 // Scalability structure (SS).
 //
 //      +-+-+-+-+-+-+-+-+
@@ skipping 34 matching lines @@
   }
   if (g_bit) {
     RETURN_FALSE_ON_ERROR(writer->WriteUInt8(vp9.gof.num_frames_in_gof));
   }
   for (size_t i = 0; i < vp9.gof.num_frames_in_gof; ++i) {
     RETURN_FALSE_ON_ERROR(writer->WriteBits(vp9.gof.temporal_idx[i], 3));
     RETURN_FALSE_ON_ERROR(
         writer->WriteBits(vp9.gof.temporal_up_switch[i] ? 1 : 0, 1));
     RETURN_FALSE_ON_ERROR(writer->WriteBits(vp9.gof.num_ref_pics[i], 2));
     RETURN_FALSE_ON_ERROR(writer->WriteBits(kReservedBitValue0, 2));
-    for (size_t r = 0; r < vp9.gof.num_ref_pics[i]; ++r) {
+    for (uint8_t r = 0; r < vp9.gof.num_ref_pics[i]; ++r) {
       RETURN_FALSE_ON_ERROR(writer->WriteUInt8(vp9.gof.pid_diff[i][r]));
     }
   }
   return true;
 }
 
 // Picture ID:
 //
 //      +-+-+-+-+-+-+-+-+
 // I:   |M| PICTURE ID  |   M:0 => picture id is 7 bits.
@@ skipping 138 matching lines @@
   for (size_t i = 0; i < vp9->gof.num_frames_in_gof; ++i) {
     uint32_t t, u_bit, r;
     RETURN_FALSE_ON_ERROR(parser->ReadBits(&t, 3));
     RETURN_FALSE_ON_ERROR(parser->ReadBits(&u_bit, 1));
     RETURN_FALSE_ON_ERROR(parser->ReadBits(&r, 2));
     RETURN_FALSE_ON_ERROR(parser->ConsumeBits(2));
     vp9->gof.temporal_idx[i] = t;
     vp9->gof.temporal_up_switch[i] = u_bit ? true : false;
     vp9->gof.num_ref_pics[i] = r;
 
-    for (size_t p = 0; p < vp9->gof.num_ref_pics[i]; ++p) {
+    for (uint8_t p = 0; p < vp9->gof.num_ref_pics[i]; ++p) {
       uint8_t p_diff;
       RETURN_FALSE_ON_ERROR(parser->ReadUInt8(&p_diff));
       vp9->gof.pid_diff[i][p] = p_diff;
     }
   }
   return true;
 }
 
 // Gets the size of next payload chunk to send. Returns 0 on error.
 size_t CalcNextSize(size_t max_length, size_t rem_bytes) {
@@ skipping 266 matching lines @@
   if (parsed_payload->payload_length == 0) {
     LOG(LS_ERROR) << "Failed parsing VP9 payload data.";
     return false;
   }
   parsed_payload->payload =
       payload + payload_length - parsed_payload->payload_length;
 
   return true;
 }
 }  // namespace webrtc