Chromium Code Reviews

Issue 1409513005: Add screenshare perf tests with lossy links (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add screenshare perf tests with lossy links BUG= Committed: https://crrev.com/4af0f1a098bc908cfe825981b825687673d5134a Cr-Commit-Position: refs/heads/master@{#10290}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+24 lines, -0 lines)
M webrtc/video/full_stack.cc View 1 chunk +24 lines, -0 lines 0 comments

Messages

Total messages: 8 (2 generated)
sprang_webrtc
5 years, 2 months ago (2015-10-15 13:09:16 UTC) #2
pbos-webrtc
lgtm
5 years, 2 months ago (2015-10-15 14:38:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409513005/1
5 years, 2 months ago (2015-10-15 14:48:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 15:34:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4af0f1a098bc908cfe825981b825687673d5134a Cr-Commit-Position: refs/heads/master@{#10290}
5 years, 2 months ago (2015-10-15 15:34:12 UTC) #7
sprang_webrtc
5 years, 2 months ago (2015-10-19 10:58:59 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1415603002/ by sprang@webrtc.org.

The reason for reverting is: Reverting to see of this resolves build bot
failures (Nexus 7.2, especially debug) which now seems to sometimes fail to
start tests altogether..

Powered by Google App Engine