Remove network_enabled_crit_ in call.cc.

Remove network_enabled_crit_ in call.cc.

After #10321 (5a289393928c18af580c6339ba77600fb67006e2) I don't see that
we still need this lock.

R=pbos@webrtc.org, solenberg@webrtc.org

Committed: https://crrev.com/717432f13016d2668a584bfd864338ecffd106b2
Cr-Commit-Position: refs/heads/master@{#10410}

[mflodman, 2015-10-22 15:14:57]

mflodman@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[mflodman, 2015-10-22 15:14:58]

Please take a look Fredrik.

[pbos-webrtc, 2015-10-22 15:19:10]

pbos@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2015-10-22 15:19:11]

https://codereview.webrtc.org/1409193003/diff/1/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/1409193003/diff/1/webrtc/call/call.cc#newcode206
webrtc/call/call.cc:206: if (!network_enabled_)
Do this outside write_lock.

https://codereview.webrtc.org/1409193003/diff/1/webrtc/call/call.cc#newcode293
webrtc/call/call.cc:293: send_stream->SignalNetworkState(kNetworkDown);
Do this before taking write_lock.

[mflodman, 2015-10-22 15:26:15]

Thanks Peter, too focused on removing the locks I missed the obvious :/

https://codereview.webrtc.org/1409193003/diff/1/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/1409193003/diff/1/webrtc/call/call.cc#newcode206
webrtc/call/call.cc:206: if (!network_enabled_)
On 2015/10/22 15:19:11, pbos-webrtc wrote:
> Do this outside write_lock.

Done.

https://codereview.webrtc.org/1409193003/diff/1/webrtc/call/call.cc#newcode293
webrtc/call/call.cc:293: send_stream->SignalNetworkState(kNetworkDown);
On 2015/10/22 15:19:10, pbos-webrtc wrote:
> Do this before taking write_lock.

Done.

[the sun, 2015-10-23 07:57:30]

lgtm

[pbos-webrtc, 2015-10-23 09:19:39]

lgtm

[mflodman, 2015-10-26 12:35:39]

The CQ bit was checked by mflodman@webrtc.org

[commit-bot: I haz the power, 2015-10-26 12:35:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409193003/20001

[commit-bot: I haz the power, 2015-10-26 14:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 14:35:57]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2015-10-26 15:31:56]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-10-26 15:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409193003/20001

[mflodman, 2015-10-26 15:34:32]

The CQ bit was unchecked by mflodman@webrtc.org

[mflodman, 2015-10-26 15:35:03]

Committed patchset #2 (id:20001) manually as
717432f13016d2668a584bfd864338ecffd106b2 (presubmit successful).

[commit-bot: I haz the power, 2015-10-26 15:35:05]

Patchset 2 (id:??) landed as
https://crrev.com/717432f13016d2668a584bfd864338ecffd106b2
Cr-Commit-Position: refs/heads/master@{#10410}