Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1408873005: Remove two more deprecated methods from SocketAddress API. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, juberti2, Sergey Ulanov, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove two more deprecated methods from SocketAddress API. This patch removes IPToString and IPToSensitiveString static helper methods, since there are class methods that replace them already, and they aren't used by anyone anymore. BUG=None R=pthacher@webrtc.org Committed: https://crrev.com/90d67ddc1df6dc5377d7a84611d4e102b42c4933 Cr-Commit-Position: refs/heads/master@{#10391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M webrtc/base/socketaddress.h View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/base/socketaddress.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tfarina
5 years, 2 months ago (2015-10-22 23:31:58 UTC) #1
tfarina
pthatcher, could you review this to me? Looks like jialy passed this to you instead.
5 years, 2 months ago (2015-10-23 12:11:24 UTC) #4
pthatcher1
lgtm
5 years, 2 months ago (2015-10-23 17:44:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408873005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408873005/1
5 years, 2 months ago (2015-10-23 18:20:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 18:22:04 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 18:22:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90d67ddc1df6dc5377d7a84611d4e102b42c4933
Cr-Commit-Position: refs/heads/master@{#10391}

Powered by Google App Engine
This is Rietveld 408576698