Add PRESUBMIT check for native API changes.

Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path (since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path that doesn't exist to the list and verified it produces an error.
NOTRY=True

Committed: https://crrev.com/53047c9739989251cbe7090865411b1469b47f5d
Cr-Commit-Position: refs/heads/master@{#10878}

[kjellander_webrtc, 2015-11-25 17:44:47]

Description was changed from

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
==========

to

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path
(since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path
that doesn't exist to the list and verified it produces an error.
==========

[kjellander_webrtc, 2015-11-25 17:44:47]

kjellander@webrtc.org changed reviewers:
+ phoglund@webrtc.org, tommi@webrtc.org

[kjellander_webrtc, 2015-11-25 17:45:06]

phoglund: Python experise.
tommi: rubberstamp.

[tommi, 2015-11-25 18:01:52]

lgtm

[Andrew MacDonald, 2015-11-25 19:10:39]

andrew@webrtc.org changed reviewers:
+ andrew@webrtc.org

[Andrew MacDonald, 2015-11-25 19:10:40]

Drive-by.

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode20
PRESUBMIT.py:20: 'webrtc/common_audio/include',  # DEPRECATED (will go away).
I think there are several users of common_audio. At least something in Chromium
is depending on the wav file handling.

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode21
PRESUBMIT.py:21: 'webrtc/modules/audio_coding/main/include',
nit: Before we publish this as an "official" directory, any way we can finally
cause this legacy "main" thing to die?

[kjellander_webrtc, 2015-11-25 22:16:51]

https://codereview.chromium.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1408783008/diff/40001/PRESUBMIT.py#newcode20
PRESUBMIT.py:20: 'webrtc/common_audio/include',  # DEPRECATED (will go away).
On 2015/11/25 19:10:40, Andrew MacDonald wrote:
> I think there are several users of common_audio. At least something in
Chromium
> is depending on the wav file handling.

Yes, but AFAIK the plan is to get rid of that and remove it as a supported API,
that's why I put this in here (to signal that new customers shouldn't attempt to
depend on it).

https://codereview.chromium.org/1408783008/diff/40001/PRESUBMIT.py#newcode21
PRESUBMIT.py:21: 'webrtc/modules/audio_coding/main/include',
On 2015/11/25 19:10:40, Andrew MacDonald wrote:
> nit: Before we publish this as an "official" directory, any way we can finally
> cause this legacy "main" thing to die?

Alright, I'll take care of this one too. I created
https://codereview.webrtc.org/1481493004/

[Andrew MacDonald, 2015-11-25 23:07:44]

andrew@webrtc.org changed reviewers:
+ aluebs@webrtc.org

[Andrew MacDonald, 2015-11-25 23:09:53]

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode20
PRESUBMIT.py:20: 'webrtc/common_audio/include',  # DEPRECATED (will go away).
On 2015/11/25 22:16:51, kjellander (webrtc) wrote:
> On 2015/11/25 19:10:40, Andrew MacDonald wrote:
> > I think there are several users of common_audio. At least something in
> Chromium
> > is depending on the wav file handling.
> 
> Yes, but AFAIK the plan is to get rid of that and remove it as a supported
API,
> that's why I put this in here (to signal that new customers shouldn't attempt
to
> depend on it).

OK. +aluebs for visibility as I believe beamer/ is using stuff in here. I'll let
you guys take that up off-review :-)

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode21
PRESUBMIT.py:21: 'webrtc/modules/audio_coding/main/include',
On 2015/11/25 22:16:51, kjellander (webrtc) wrote:
> On 2015/11/25 19:10:40, Andrew MacDonald wrote:
> > nit: Before we publish this as an "official" directory, any way we can
finally
> > cause this legacy "main" thing to die?
> 
> Alright, I'll take care of this one too. I created
> https://codereview.webrtc.org/1481493004/

Thanks! RIP main.

[aluebs-webrtc, 2015-11-25 23:54:46]

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode20
PRESUBMIT.py:20: 'webrtc/common_audio/include',  # DEPRECATED (will go away).
On 2015/11/25 23:09:53, Andrew MacDonald wrote:
> On 2015/11/25 22:16:51, kjellander (webrtc) wrote:
> > On 2015/11/25 19:10:40, Andrew MacDonald wrote:
> > > I think there are several users of common_audio. At least something in
> > Chromium
> > > is depending on the wav file handling.
> > 
> > Yes, but AFAIK the plan is to get rid of that and remove it as a supported
> API,
> > that's why I put this in here (to signal that new customers shouldn't
attempt
> to
> > depend on it).
> 
> OK. +aluebs for visibility as I believe beamer/ is using stuff in here. I'll
let
> you guys take that up off-review :-)

Yes, common_audio is extensively used in beamer, in particular:
* channel_buffer.h
* wav_file.h
* lapped_transform.h
* real_fourier.h
* window_generator.h
* audio_ring_buffer.h
* audio_util.h
* fir_filter.h
But I am not sure what a sufficient reason is to add it to the NATIVE_API list.
Anyway, we can take this off-line.

[kjellander_webrtc, 2015-11-26 08:37:15]

kjellander@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kjellander_webrtc, 2015-11-26 08:37:53]

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode20
PRESUBMIT.py:20: 'webrtc/common_audio/include',  # DEPRECATED (will go away).
On 2015/11/25 23:54:45, aluebs-webrtc wrote:
> On 2015/11/25 23:09:53, Andrew MacDonald wrote:
> > On 2015/11/25 22:16:51, kjellander (webrtc) wrote:
> > > On 2015/11/25 19:10:40, Andrew MacDonald wrote:
> > > > I think there are several users of common_audio. At least something in
> > > Chromium
> > > > is depending on the wav file handling.
> > > 
> > > Yes, but AFAIK the plan is to get rid of that and remove it as a supported
> > API,
> > > that's why I put this in here (to signal that new customers shouldn't
> attempt
> > to
> > > depend on it).
> > 
> > OK. +aluebs for visibility as I believe beamer/ is using stuff in here. I'll
> let
> > you guys take that up off-review :-)
> 
> Yes, common_audio is extensively used in beamer, in particular:
> * channel_buffer.h
> * wav_file.h
> * lapped_transform.h
> * real_fourier.h
> * window_generator.h
> * audio_ring_buffer.h
> * audio_util.h
> * fir_filter.h
> But I am not sure what a sufficient reason is to add it to the NATIVE_API
list.
> Anyway, we can take this off-line.

Please discuss this with Henrik L (added to review now).

[phoglund, 2015-11-26 09:52:07]

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode76
PRESUBMIT.py:76: '  4. Update/inform existing clients to update their code to
the new '
There is really no way for anyone to know what the "existing clients" are,
either internally or externally. Should we just say "announce the change on
discuss-webrtc and remove the deprecated method after waiting at least three
months?"

[Andrew MacDonald, 2015-11-26 17:13:20]

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode76
PRESUBMIT.py:76: '  4. Update/inform existing clients to update their code to
the new '
On 2015/11/26 09:52:07, phoglund wrote:
> There is really no way for anyone to know what the "existing clients" are,
> either internally or externally. Should we just say "announce the change on
> discuss-webrtc and remove the deprecated method after waiting at least three
> months?"

And probably webrtc-users, since I doubt many Google internal users are
monitoring discuss-webrtc?

[kjellander_webrtc, 2015-11-27 07:06:59]

Updated the information message and the audio_coding path after landing
https://codereview.webrtc.org/1481493004/

PTAL

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/40001/PRESUBMIT.py#newcode76
PRESUBMIT.py:76: '  4. Update/inform existing clients to update their code to
the new '
On 2015/11/26 17:13:20, Andrew MacDonald wrote:
> On 2015/11/26 09:52:07, phoglund wrote:
> > There is really no way for anyone to know what the "existing clients" are,
> > either internally or externally. Should we just say "announce the change on
> > discuss-webrtc and remove the deprecated method after waiting at least three
> > months?"
> 
> And probably webrtc-users, since I doubt many Google internal users are
> monitoring discuss-webrtc?

Right, I guess externals cannot post to this list anyway, so it shouldn't be a
problem.

[hlundin-webrtc, 2015-11-27 07:46:13]

https://codereview.webrtc.org/1408783008/diff/80001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/80001/PRESUBMIT.py#newcode72
PRESUBMIT.py:72: '  1. Make compatible changes that doesn\'t break existing
clients.\n'
doesn't -> don't
(Native English speakers: please correct me if I'm wrong.)

https://codereview.webrtc.org/1408783008/diff/80001/PRESUBMIT.py#newcode76
PRESUBMIT.py:76: '  4. Update/inform existing downstream code to update their
code to '
Inform the code to update their code? Have we reached the singularity? :)

Suggest:
"Urge downstream code owners to stop using the deprecated APIs."

[kjellander_webrtc, 2015-11-27 08:40:32]

Another round...

https://codereview.webrtc.org/1408783008/diff/80001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/80001/PRESUBMIT.py#newcode72
PRESUBMIT.py:72: '  1. Make compatible changes that doesn\'t break existing
clients.\n'
On 2015/11/27 07:46:13, hlundin-webrtc wrote:
> doesn't -> don't
> (Native English speakers: please correct me if I'm wrong.)

Thanks.

https://codereview.webrtc.org/1408783008/diff/80001/PRESUBMIT.py#newcode76
PRESUBMIT.py:76: '  4. Update/inform existing downstream code to update their
code to '
On 2015/11/27 07:46:13, hlundin-webrtc wrote:
> Inform the code to update their code? Have we reached the singularity? :)
> 
> Suggest:
> "Urge downstream code owners to stop using the deprecated APIs."

Oops :) thanks for correcting this.

[hlundin-webrtc, 2015-11-27 08:44:28]

lgtm

[Andrew MacDonald, 2015-11-30 17:12:36]

https://codereview.webrtc.org/1408783008/diff/100001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/100001/PRESUBMIT.py#newcode36
PRESUBMIT.py:36: 'webrtc/system_wrappers/include',
This should be deprecated to, no? If anything webrtc/base should be available,
but I doubt we want dependence on that.

[kjellander_webrtc, 2015-11-30 17:29:26]

https://codereview.webrtc.org/1408783008/diff/100001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1408783008/diff/100001/PRESUBMIT.py#newcode36
PRESUBMIT.py:36: 'webrtc/system_wrappers/include',
On 2015/11/30 17:12:36, Andrew MacDonald wrote:
> This should be deprecated to, no? If anything webrtc/base should be available,
> but I doubt we want dependence on that.

That makes sense. I added a similar comment for it.

[Andrew MacDonald, 2015-11-30 18:03:57]

lgtm, fwiw :-)

[kjellander_webrtc, 2015-12-02 09:14:40]

phoglund: ready for approval or do you have more comments?

[phoglund, 2015-12-02 12:22:43]

lgtm

[kjellander_webrtc, 2015-12-03 07:54:34]

Description was changed from

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path
(since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path
that doesn't exist to the list and verified it produces an error.
==========

to

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path
(since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path
that doesn't exist to the list and verified it produces an error.
NOTRY=True
==========

[kjellander_webrtc, 2015-12-03 07:54:38]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2015-12-03 07:54:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1408783008/#ps120001 (title:
"Rebase + added deprecation notice for system_wrappers")

[commit-bot: I haz the power, 2015-12-03 07:54:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408783008/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408783008/120001

[commit-bot: I haz the power, 2015-12-03 07:56:16]

Description was changed from

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path
(since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path
that doesn't exist to the list and verified it produces an error.
NOTRY=True
==========

to

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path
(since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path
that doesn't exist to the list and verified it produces an error.
NOTRY=True
==========

[commit-bot: I haz the power, 2015-12-03 07:56:17]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-12-03 07:56:27]

Description was changed from

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path
(since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path
that doesn't exist to the list and verified it produces an error.
NOTRY=True
==========

to

==========
Add PRESUBMIT check for native API changes.

BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path
(since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path
that doesn't exist to the list and verified it produces an error.
NOTRY=True

Committed: https://crrev.com/53047c9739989251cbe7090865411b1469b47f5d
Cr-Commit-Position: refs/heads/master@{#10878}
==========

[commit-bot: I haz the power, 2015-12-03 07:56:28]

Patchset 7 (id:??) landed as
https://crrev.com/53047c9739989251cbe7090865411b1469b47f5d
Cr-Commit-Position: refs/heads/master@{#10878}