Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1407893005: Revert "Add GN Build file for rtc_sound target." (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years, 1 month ago
Reviewers:
tfarina
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Add GN Build file for rtc_sound target." This reverts commit f054819e257a4f9cbb7fa82ba51dc2335f4359ec, 2d3747de9b7c3014e106d3766dc07cf5da3e1881 and 7ef0553c85c5b373535d7f6161e9a6d3b5b9a826. It seems harder than expected to get a GN build for rtc_sound and we lack sufficient trybot support for the case where WebRTC is built as part of Chromium. The Debug builds failed like this: [6939/7454] SOLINK ./libcontent.so FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=all -pthread -m64 -Wl,--export-dynamic -o ./libcontent.so -Wl,-soname=libcontent.so @./libcontent.so.rsp && { readelf -d ./libcontent.so | grep SONAME ; nm -gD -f p ./libcontent.so | cut -f1-2 -d' '; } > ./libcontent.so.tmp && if ! cmp -s ./libcontent.so.tmp ./libcontent.so.TOC; then mv ./libcontent.so.tmp ./libcontent.so.TOC; fi ../../third_party/webrtc/sound/alsasoundsystem.cc:453: error: undefined reference to 'rtc::LateBindingSymbolTable::Load()' ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined reference to 'rtc::LateBindingSymbolTable::IsLoaded() const' ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined reference to 'rtc::LateBindingSymbolTable::IsLoaded() const' ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined reference to 'rtc::LateBindingSymbolTable::IsLoaded() const' ../../third_party/webrtc/base/latebindingsymboltable.h.def:62: error: undefined reference to 'rtc::LateBindingSymbolTable::IsLoaded() const' ../../third_party/webrtc/base/latebindingsymboltable.cc.def:63: error: undefined reference to 'rtc::LateBindingSymbolTable::LateBindingSymbolTable(rtc::LateBindingSymbolTable::TableInfo const*, void**)' ../../third_party/webrtc/base/latebindingsymboltable.cc.def:65: error: undefined reference to 'rtc::LateBindingSymbolTable::~LateBindingSymbolTable()' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. BUG=webrtc:4160 TBR=tfarina@chromium.org Committed: https://crrev.com/c4ef1439f6e114dd0cde36de1bf7d43fcea05aa3 Cr-Commit-Position: refs/heads/master@{#10411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -60 lines) Patch
M webrtc/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
D webrtc/sound/BUILD.gn View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
Thanks for the patches Thiago. I think it's just a minor change needed to get ...
5 years, 1 month ago (2015-10-26 16:39:06 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as c4ef1439f6e114dd0cde36de1bf7d43fcea05aa3 (presubmit successful).
5 years, 1 month ago (2015-10-26 16:39:26 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4ef1439f6e114dd0cde36de1bf7d43fcea05aa3 Cr-Commit-Position: refs/heads/master@{#10411}
5 years, 1 month ago (2015-10-26 16:39:32 UTC) #5
tfarina
5 years, 1 month ago (2015-10-26 18:17:12 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698