Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: talk/media/webrtc/simulcast.h

Issue 1407693005: Remove simulcast bitrate modes. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: remove constants Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/mediachannel.h ('k') | talk/media/webrtc/simulcast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/simulcast.h
diff --git a/talk/media/webrtc/simulcast.h b/talk/media/webrtc/simulcast.h
index 0f238733da56b4b75944ac9edd052d4cd68e6888..68d0aaebadc30806866aeebeee6e3615bc20b6df 100755
--- a/talk/media/webrtc/simulcast.h
+++ b/talk/media/webrtc/simulcast.h
@@ -33,21 +33,9 @@
#include "webrtc/base/basictypes.h"
#include "webrtc/config.h"
-namespace webrtc {
-struct VideoCodec;
-}
-
namespace cricket {
-struct VideoOptions;
struct StreamParams;
-enum SimulcastBitrateMode {
- SBM_NORMAL = 0,
- SBM_HIGH,
- SBM_VERY_HIGH,
- SBM_COUNT
-};
-
// Config for use with screen cast when temporal layers are enabled.
struct ScreenshareLayerConfig {
public:
@@ -68,57 +56,18 @@ struct ScreenshareLayerConfig {
// TODO(pthatcher): Write unit tests just for these functions,
// independent of WebrtcVideoEngine.
-// Get the simulcast bitrate mode to use based on
-// options.video_highest_bitrate.
-SimulcastBitrateMode GetSimulcastBitrateMode(
- const VideoOptions& options);
+int GetTotalMaxBitrateBps(const std::vector<webrtc::VideoStream>& streams);
// Get the ssrcs of the SIM group from the stream params.
void GetSimulcastSsrcs(const StreamParams& sp, std::vector<uint32_t>* ssrcs);
// Get simulcast settings.
-std::vector<webrtc::VideoStream> GetSimulcastConfig(
- size_t max_streams,
- SimulcastBitrateMode bitrate_mode,
- int width,
- int height,
- int max_bitrate_bps,
- int max_qp,
- int max_framerate);
-
-// Set the codec->simulcastStreams, codec->width, and codec->height
-// based on the number of ssrcs to use and the bitrate mode to use.
-bool ConfigureSimulcastCodec(int number_ssrcs,
- SimulcastBitrateMode bitrate_mode,
- webrtc::VideoCodec* codec);
-
-// Set the codec->simulcastStreams, codec->width, and codec->height
-// based on the video options (to get the simulcast bitrate mode) and
-// the stream params (to get the number of ssrcs). This is really a
-// convenience function.
-bool ConfigureSimulcastCodec(const StreamParams& sp,
- const VideoOptions& options,
- webrtc::VideoCodec* codec);
-
-// Set the numberOfTemporalLayers in each codec->simulcastStreams[i].
-// Apparently it is useful to do this at a different time than
-// ConfigureSimulcastCodec.
-// TODO(pthatcher): Figure out why and put this code into
-// ConfigureSimulcastCodec.
-void ConfigureSimulcastTemporalLayers(
- int num_temporal_layers, webrtc::VideoCodec* codec);
-
-// Turn off all simulcasting for the given codec.
-void DisableSimulcastCodec(webrtc::VideoCodec* codec);
-
-// Log useful info about each of the simulcast substreams of the
-// codec.
-void LogSimulcastSubstreams(const webrtc::VideoCodec& codec);
-
-// Configure the codec's bitrate and temporal layers so that it's good
-// for a screencast in conference mode. Technically, this shouldn't
-// go in simulcast.cc. But it's closely related.
-void ConfigureConferenceModeScreencastCodec(webrtc::VideoCodec* codec);
+std::vector<webrtc::VideoStream> GetSimulcastConfig(size_t max_streams,
+ int width,
+ int height,
+ int max_bitrate_bps,
+ int max_qp,
+ int max_framerate);
} // namespace cricket
« no previous file with comments | « talk/media/base/mediachannel.h ('k') | talk/media/webrtc/simulcast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698