Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407693005: Remove simulcast bitrate modes. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove simulcast bitrate modes. Instead always use the SBM_VERY_HIGH setting. BUG=webrtc:4885 R=hta@webrtc.org, mflodman@webrtc.org Committed: https://crrev.com/be16f79818d7c21b747189b3e86d8d98add3e6b1 Cr-Commit-Position: refs/heads/master@{#10305}

Patch Set 1 #

Patch Set 2 : remove constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -340 lines) Patch
M talk/app/webrtc/mediaconstraintsinterface.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M talk/app/webrtc/mediaconstraintsinterface.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M talk/media/base/mediachannel.h View 6 chunks +0 lines, -12 lines 0 comments Download
M talk/media/webrtc/simulcast.h View 2 chunks +7 lines, -58 lines 0 comments Download
M talk/media/webrtc/simulcast.cc View 9 chunks +22 lines, -204 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 chunk +1 line, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 5 chunks +7 lines, -42 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
pbos-webrtc
remove constants
5 years, 2 months ago (2015-10-15 16:10:32 UTC) #1
pbos-webrtc
PTAL: hta@ for talk/app and talk/media/base. mflodman@ for talk/media/webrtc/.
5 years, 2 months ago (2015-10-15 16:12:07 UTC) #2
hta - Chromium
LGTM for my parts. (reviewing removal of code feels SO good....)
5 years, 2 months ago (2015-10-15 17:49:29 UTC) #4
mflodman
On 2015/10/15 17:49:29, hta - Chromium wrote: > LGTM for my parts. > (reviewing removal ...
5 years, 2 months ago (2015-10-16 11:52:25 UTC) #5
mflodman
LGTM
5 years, 2 months ago (2015-10-16 13:55:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407693005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407693005/20001
5 years, 2 months ago (2015-10-16 14:06:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1260)
5 years, 2 months ago (2015-10-16 14:12:32 UTC) #10
hta-webrtc
lgtm
5 years, 2 months ago (2015-10-16 19:40:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407693005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407693005/20001
5 years, 2 months ago (2015-10-16 19:41:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 19:49:43 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 19:49:58 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/be16f79818d7c21b747189b3e86d8d98add3e6b1
Cr-Commit-Position: refs/heads/master@{#10305}

Powered by Google App Engine
This is Rietveld 408576698