Correctly handle the error case where the CodecId has a negative value

Correctly handle the error case where the CodecId has a negative value

Negative values should be treated the same as too-large positive values: by returning an empty Maybe.

TBR=henrik.lundin@webrtc.org

Committed: https://crrev.com/98cc88c87354c96a88cebbd7b803815b4ebeea95
Cr-Commit-Position: refs/heads/master@{#10509}

[kwiberg-webrtc, 2015-11-04 09:00:49]

Description was changed from

==========
Correctly handle the error case where the CodecId has a negative value
==========

to

==========
Correctly handle the error case where the CodecId has a negative value

Negative values should be treated the same as too-large positive values: by
returning an empty Maybe.
==========

[kwiberg-webrtc, 2015-11-04 09:00:49]

kwiberg@webrtc.org changed reviewers:
+ pkasting@chromium.org

[kwiberg-webrtc, 2015-11-04 09:02:48]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org
- pkasting@chromium.org

[kwiberg-webrtc, 2015-11-04 09:02:49]

PTAL

[hlundin-webrtc, 2015-11-04 11:03:42]

https://codereview.webrtc.org/1407383010/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/rent_a_codec.h (right):

https://codereview.webrtc.org/1407383010/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/rent_a_codec.h:135: const size_t i =
static_cast<size_t>(codec_id);
No sir, I didn't like it.
I prefer augmenting the original conditional instead of casting and re-casting:
return i>= 0 && i < static_cast<int>(NumberOfCodecs()) ? ...;

[kwiberg-webrtc, 2015-11-04 14:27:59]

New patch set posted.

https://codereview.webrtc.org/1407383010/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/rent_a_codec.h (right):

https://codereview.webrtc.org/1407383010/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/rent_a_codec.h:135: const size_t i =
static_cast<size_t>(codec_id);
On 2015/11/04 11:03:42, hlundin-webrtc wrote:
> No sir, I didn't like it.
> I prefer augmenting the original conditional instead of casting and
re-casting:
> return i>= 0 && i < static_cast<int>(NumberOfCodecs()) ? ...;

Done.

[kwiberg-webrtc, 2015-11-04 17:54:45]

Description was changed from

==========
Correctly handle the error case where the CodecId has a negative value

Negative values should be treated the same as too-large positive values: by
returning an empty Maybe.
==========

to

==========
Correctly handle the error case where the CodecId has a negative value

Negative values should be treated the same as too-large positive values: by
returning an empty Maybe.

TBR=henrik.lundin@webrtc.org
==========

[kwiberg-webrtc, 2015-11-04 17:54:57]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-11-04 17:55:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407383010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407383010/20001

[commit-bot: I haz the power, 2015-11-04 17:56:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-04 17:56:31]

Patchset 2 (id:??) landed as
https://crrev.com/98cc88c87354c96a88cebbd7b803815b4ebeea95
Cr-Commit-Position: refs/heads/master@{#10509}

[hlundin-webrtc, 2015-11-05 08:06:50]

lgtm