Chromium Code Reviews

Issue 1407053008: Fix win32 header include order in rtp_utility.h. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix win32 header include order in rtp_utility.h. Matches the include order in webrtc/base/criticalsection.h and makes use of winsock2.h instead of winsock.h for consistency. BUG= R=tommi@webrtc.org Committed: https://crrev.com/a99069db6397ca9377ed473cdbfc6c4a53e22d98 Cr-Commit-Position: refs/heads/master@{#10389}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -4 lines)
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +2 lines, -4 lines 0 comments

Messages

Total messages: 9 (3 generated)
pbos-webrtc
PTAL woo
5 years, 2 months ago (2015-10-23 12:12:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407053008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407053008/1
5 years, 2 months ago (2015-10-23 12:12:46 UTC) #3
tommi
lgtm
5 years, 2 months ago (2015-10-23 12:51:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407053008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407053008/1
5 years, 2 months ago (2015-10-23 13:09:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 13:32:42 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 13:32:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a99069db6397ca9377ed473cdbfc6c4a53e22d98
Cr-Commit-Position: refs/heads/master@{#10389}

Powered by Google App Engine