Chromium Code Reviews| Index: webrtc/modules/video_coding/main/source/video_receiver.cc |
| diff --git a/webrtc/modules/video_coding/main/source/video_receiver.cc b/webrtc/modules/video_coding/main/source/video_receiver.cc |
| index 2e23b5ef6996113d2e14f2ec97bad0f3957b602f..b0f3026f393c0ba084e204da269e294b889315de 100644 |
| --- a/webrtc/modules/video_coding/main/source/video_receiver.cc |
| +++ b/webrtc/modules/video_coding/main/source/video_receiver.cc |
| @@ -291,43 +291,37 @@ int32_t VideoReceiver::Decode(uint16_t maxWaitTimeMs) { |
| VCMEncodedFrame* frame = _receiver.FrameForDecoding( |
| maxWaitTimeMs, nextRenderTimeMs, supports_render_scheduling); |
| - if (frame == NULL) { |
| + if (frame == NULL) |
| return VCM_FRAME_NOT_READY; |
| - } else { |
| - CriticalSectionScoped cs(_receiveCritSect); |
| - // If this frame was too late, we should adjust the delay accordingly |
| - _timing.UpdateCurrentDelay(frame->RenderTimeMs(), |
| - clock_->TimeInMilliseconds()); |
| + CriticalSectionScoped cs(_receiveCritSect); |
| - if (pre_decode_image_callback_) { |
| - EncodedImage encoded_image(frame->EncodedImage()); |
| - int qp = -1; |
| - if (qp_parser_.GetQp(*frame, &qp)) { |
| - encoded_image.qp_ = qp; |
| - } |
| - pre_decode_image_callback_->Encoded( |
| - encoded_image, frame->CodecSpecific(), NULL); |
| + // If this frame was too late, we should adjust the delay accordingly |
| + _timing.UpdateCurrentDelay(frame->RenderTimeMs(), |
| + clock_->TimeInMilliseconds()); |
| + |
| + if (pre_decode_image_callback_) { |
| + EncodedImage encoded_image(frame->EncodedImage()); |
| + int qp = -1; |
| + if (qp_parser_.GetQp(*frame, &qp)) { |
| + encoded_image.qp_ = qp; |
| } |
| + pre_decode_image_callback_->Encoded(encoded_image, frame->CodecSpecific(), |
| + NULL); |
| + } |
| #ifdef DEBUG_DECODER_BIT_STREAM |
| - if (_bitStreamBeforeDecoder != NULL) { |
| - // Write bit stream to file for debugging purposes |
| - if (fwrite( |
| - frame->Buffer(), 1, frame->Length(), _bitStreamBeforeDecoder) != |
| - frame->Length()) { |
| - return -1; |
| - } |
| - } |
| -#endif |
| - const int32_t ret = Decode(*frame); |
| - _receiver.ReleaseFrame(frame); |
| - frame = NULL; |
| - if (ret != VCM_OK) { |
| - return ret; |
| + if (_bitStreamBeforeDecoder != NULL) { |
| + // Write bit stream to file for debugging purposes |
| + if (fwrite(frame->Buffer(), 1, frame->Length(), _bitStreamBeforeDecoder) != |
| + frame->Length()) { |
| + return -1; |
| } |
| } |
| - return VCM_OK; |
| +#endif |
| + const int32_t ret = Decode(*frame); |
| + _receiver.ReleaseFrame(frame); |
| + return ret; |
|
stefan-webrtc
2015/10/27 08:31:53
Did you mean to change this code? Is it only forma
pbos-webrtc
2015/10/27 12:16:59
Yes, early-return if (frame == NULL) instead of ha
|
| } |
| int32_t VideoReceiver::RequestSliceLossIndication( |