Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: talk/app/webrtc/statstypes.cc

Issue 1406903002: Expose codec implementation names in stats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: report what we fell back from Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/statstypes.cc
diff --git a/talk/app/webrtc/statstypes.cc b/talk/app/webrtc/statstypes.cc
index e45833c668a7c04aa375033e1573b1f683ec1fa6..29bb20635495cc1aede619389bbe52fa39b47072 100644
--- a/talk/app/webrtc/statstypes.cc
+++ b/talk/app/webrtc/statstypes.cc
@@ -409,6 +409,13 @@ const char* StatsReport::Value::display_name() const {
case kStatsValueNameDataChannelId:
return "datachannelid";
+ // Codec 'implementationName' constants tracked here:
+ // https://code.google.com/p/webrtc/issues/detail?id=4897
+ case kStatsValueNameDecoderImplementationName:
+ return "decoderImplementationName";
+ case kStatsValueNameEncoderImplementationName:
+ return "encoderImplementationName";
+
// 'goog' prefixed constants.
case kStatsValueNameAccelerateRate:
return "googAccelerateRate";
@@ -592,9 +599,6 @@ const char* StatsReport::Value::display_name() const {
return "googViewLimitedResolution";
case kStatsValueNameWritable:
return "googWritable";
- default:
- RTC_DCHECK(false);
- break;
}
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698