Expose codec implementation names in stats.

talk/app/webrtc/statstypes.cc

Index: talk/app/webrtc/statstypes.cc
diff --git a/talk/app/webrtc/statstypes.cc b/talk/app/webrtc/statstypes.cc
index e45833c668a7c04aa375033e1573b1f683ec1fa6..29bb20635495cc1aede619389bbe52fa39b47072 100644
--- a/talk/app/webrtc/statstypes.cc
+++ b/talk/app/webrtc/statstypes.cc
@@ -409,6 +409,13 @@ const char* StatsReport::Value::display_name() const {
     case kStatsValueNameDataChannelId:
       return "datachannelid";
 
+    // Codec 'implementationName' constants tracked here:

[hta-webrtc, 2015/10/29 11:35:02]

I don't think you want to check in bug URLs in anything but a TODO.

[pbos-webrtc, 2015/10/29 16:08:05]

Removed.

+    // https://code.google.com/p/webrtc/issues/detail?id=4897
+    case kStatsValueNameDecoderImplementationName:
+      return "decoderImplementationName";
+    case kStatsValueNameEncoderImplementationName:
+      return "encoderImplementationName";

[hta-webrtc, 2015/10/29 11:35:02]

I don't see in the bug my earlier comments that the "encoder/decoder" part is
unneccessary, because they will never occur on the same object.

[pbos-webrtc, 2015/10/29 16:08:05]

Changed to codecImplementationName for both, implementationName makes sense for
RTCCodec but not for sender, this is not the implementation name for the sender,
it's for the sender's codec.

WDYT?

+
     // 'goog' prefixed constants.
     case kStatsValueNameAccelerateRate:
       return "googAccelerateRate";
@@ -592,9 +599,6 @@ const char* StatsReport::Value::display_name() const {
       return "googViewLimitedResolution";
     case kStatsValueNameWritable:
       return "googWritable";
-    default:
-      RTC_DCHECK(false);
-      break;

[hta-webrtc, 2015/10/29 11:35:02]

Unrelated change, will cause compiler error if it would have been hit, so
probably OK.

[pbos-webrtc, 2015/10/29 16:08:04]

Acknowledged.

   }
 
   return nullptr;