Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1406903002: Expose codec implementation names in stats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: report what we fell back from Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 2347 matching lines...) Expand 10 before | Expand all | Expand 10 after
2358 parameters.codecs.push_back(kVp8Codec); 2358 parameters.codecs.push_back(kVp8Codec);
2359 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 2359 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2360 2360
2361 AddSendStream(); 2361 AddSendStream();
2362 2362
2363 cricket::VideoMediaInfo info; 2363 cricket::VideoMediaInfo info;
2364 ASSERT_TRUE(channel_->GetStats(&info)); 2364 ASSERT_TRUE(channel_->GetStats(&info));
2365 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name); 2365 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name);
2366 } 2366 }
2367 2367
2368 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsEncoderImplementationName) {
2369 FakeVideoSendStream* stream = AddSendStream();
2370 webrtc::VideoSendStream::Stats stats;
2371 stats.encoder_implementation_name = "decoder_implementation_name";
stefan-webrtc 2015/10/27 08:31:53 s/decoder/encoder
pbos-webrtc 2015/10/27 12:16:59 Done.
2372 stream->SetStats(stats);
2373
2374 cricket::VideoMediaInfo info;
2375 ASSERT_TRUE(channel_->GetStats(&info));
2376 EXPECT_EQ(stats.encoder_implementation_name,
2377 info.senders[0].encoder_implementation_name);
2378 }
2379
2368 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) { 2380 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) {
2369 FakeVideoSendStream* stream = AddSendStream(); 2381 FakeVideoSendStream* stream = AddSendStream();
2370 webrtc::VideoSendStream::Stats stats; 2382 webrtc::VideoSendStream::Stats stats;
2371 stats.avg_encode_time_ms = 13; 2383 stats.avg_encode_time_ms = 13;
2372 stats.encode_usage_percent = 42; 2384 stats.encode_usage_percent = 42;
2373 stream->SetStats(stats); 2385 stream->SetStats(stats);
2374 2386
2375 cricket::VideoMediaInfo info; 2387 cricket::VideoMediaInfo info;
2376 ASSERT_TRUE(channel_->GetStats(&info)); 2388 ASSERT_TRUE(channel_->GetStats(&info));
2377 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms); 2389 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
2509 info.receivers[0].firs_sent); 2521 info.receivers[0].firs_sent);
2510 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets, 2522 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
2511 info.receivers[0].nacks_sent); 2523 info.receivers[0].nacks_sent);
2512 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets, 2524 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
2513 info.receivers[0].plis_sent); 2525 info.receivers[0].plis_sent);
2514 } 2526 }
2515 2527
2516 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) { 2528 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) {
2517 FakeVideoReceiveStream* stream = AddRecvStream(); 2529 FakeVideoReceiveStream* stream = AddRecvStream();
2518 webrtc::VideoReceiveStream::Stats stats; 2530 webrtc::VideoReceiveStream::Stats stats;
2531 stats.decoder_implementation_name = "decoder_implementation_name";
2519 stats.decode_ms = 2; 2532 stats.decode_ms = 2;
2520 stats.max_decode_ms = 3; 2533 stats.max_decode_ms = 3;
2521 stats.current_delay_ms = 4; 2534 stats.current_delay_ms = 4;
2522 stats.target_delay_ms = 5; 2535 stats.target_delay_ms = 5;
2523 stats.jitter_buffer_ms = 6; 2536 stats.jitter_buffer_ms = 6;
2524 stats.min_playout_delay_ms = 7; 2537 stats.min_playout_delay_ms = 7;
2525 stats.render_delay_ms = 8; 2538 stats.render_delay_ms = 8;
2526 stream->SetStats(stats); 2539 stream->SetStats(stats);
2527 2540
2528 cricket::VideoMediaInfo info; 2541 cricket::VideoMediaInfo info;
2529 ASSERT_TRUE(channel_->GetStats(&info)); 2542 ASSERT_TRUE(channel_->GetStats(&info));
2543 EXPECT_EQ(stats.decoder_implementation_name,
2544 info.receivers[0].decoder_implementation_name);
2530 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms); 2545 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
2531 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms); 2546 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
2532 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms); 2547 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
2533 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms); 2548 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
2534 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms); 2549 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
2535 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms); 2550 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
2536 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms); 2551 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
2537 } 2552 }
2538 2553
2539 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) { 2554 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) {
(...skipping 686 matching lines...) Expand 10 before | Expand all | Expand 10 after
3226 // Ensures that the correct settings are applied to the codec when two temporal 3241 // Ensures that the correct settings are applied to the codec when two temporal
3227 // layer screencasting is enabled, and that the correct simulcast settings are 3242 // layer screencasting is enabled, and that the correct simulcast settings are
3228 // reapplied when disabling screencasting. 3243 // reapplied when disabling screencasting.
3229 TEST_F(WebRtcVideoChannel2SimulcastTest, 3244 TEST_F(WebRtcVideoChannel2SimulcastTest,
3230 DISABLED_TwoTemporalLayerScreencastSettings) { 3245 DISABLED_TwoTemporalLayerScreencastSettings) {
3231 // TODO(pbos): Implement. 3246 // TODO(pbos): Implement.
3232 FAIL() << "Not implemented."; 3247 FAIL() << "Not implemented.";
3233 } 3248 }
3234 3249
3235 } // namespace cricket 3250 } // namespace cricket
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698