Chromium Code Reviews

Side by Side Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1406903002: Expose codec implementation names in stats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: remove conflict marker Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 2423 matching lines...)
2434 parameters.codecs.push_back(kVp8Codec); 2434 parameters.codecs.push_back(kVp8Codec);
2435 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 2435 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2436 2436
2437 AddSendStream(); 2437 AddSendStream();
2438 2438
2439 cricket::VideoMediaInfo info; 2439 cricket::VideoMediaInfo info;
2440 ASSERT_TRUE(channel_->GetStats(&info)); 2440 ASSERT_TRUE(channel_->GetStats(&info));
2441 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name); 2441 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name);
2442 } 2442 }
2443 2443
2444 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsEncoderImplementationName) {
2445 FakeVideoSendStream* stream = AddSendStream();
2446 webrtc::VideoSendStream::Stats stats;
2447 stats.encoder_implementation_name = "encoder_implementation_name";
2448 stream->SetStats(stats);
2449
2450 cricket::VideoMediaInfo info;
2451 ASSERT_TRUE(channel_->GetStats(&info));
2452 EXPECT_EQ(stats.encoder_implementation_name,
2453 info.senders[0].encoder_implementation_name);
2454 }
2455
2444 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) { 2456 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) {
2445 FakeVideoSendStream* stream = AddSendStream(); 2457 FakeVideoSendStream* stream = AddSendStream();
2446 webrtc::VideoSendStream::Stats stats; 2458 webrtc::VideoSendStream::Stats stats;
2447 stats.avg_encode_time_ms = 13; 2459 stats.avg_encode_time_ms = 13;
2448 stats.encode_usage_percent = 42; 2460 stats.encode_usage_percent = 42;
2449 stream->SetStats(stats); 2461 stream->SetStats(stats);
2450 2462
2451 cricket::VideoMediaInfo info; 2463 cricket::VideoMediaInfo info;
2452 ASSERT_TRUE(channel_->GetStats(&info)); 2464 ASSERT_TRUE(channel_->GetStats(&info));
2453 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms); 2465 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
(...skipping 131 matching lines...)
2585 info.receivers[0].firs_sent); 2597 info.receivers[0].firs_sent);
2586 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets, 2598 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
2587 info.receivers[0].nacks_sent); 2599 info.receivers[0].nacks_sent);
2588 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets, 2600 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
2589 info.receivers[0].plis_sent); 2601 info.receivers[0].plis_sent);
2590 } 2602 }
2591 2603
2592 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) { 2604 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) {
2593 FakeVideoReceiveStream* stream = AddRecvStream(); 2605 FakeVideoReceiveStream* stream = AddRecvStream();
2594 webrtc::VideoReceiveStream::Stats stats; 2606 webrtc::VideoReceiveStream::Stats stats;
2607 stats.decoder_implementation_name = "decoder_implementation_name";
2595 stats.decode_ms = 2; 2608 stats.decode_ms = 2;
2596 stats.max_decode_ms = 3; 2609 stats.max_decode_ms = 3;
2597 stats.current_delay_ms = 4; 2610 stats.current_delay_ms = 4;
2598 stats.target_delay_ms = 5; 2611 stats.target_delay_ms = 5;
2599 stats.jitter_buffer_ms = 6; 2612 stats.jitter_buffer_ms = 6;
2600 stats.min_playout_delay_ms = 7; 2613 stats.min_playout_delay_ms = 7;
2601 stats.render_delay_ms = 8; 2614 stats.render_delay_ms = 8;
2602 stream->SetStats(stats); 2615 stream->SetStats(stats);
2603 2616
2604 cricket::VideoMediaInfo info; 2617 cricket::VideoMediaInfo info;
2605 ASSERT_TRUE(channel_->GetStats(&info)); 2618 ASSERT_TRUE(channel_->GetStats(&info));
2619 EXPECT_EQ(stats.decoder_implementation_name,
2620 info.receivers[0].decoder_implementation_name);
2606 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms); 2621 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
2607 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms); 2622 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
2608 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms); 2623 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
2609 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms); 2624 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
2610 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms); 2625 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
2611 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms); 2626 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
2612 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms); 2627 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
2613 } 2628 }
2614 2629
2615 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) { 2630 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) {
(...skipping 686 matching lines...)
3302 // Ensures that the correct settings are applied to the codec when two temporal 3317 // Ensures that the correct settings are applied to the codec when two temporal
3303 // layer screencasting is enabled, and that the correct simulcast settings are 3318 // layer screencasting is enabled, and that the correct simulcast settings are
3304 // reapplied when disabling screencasting. 3319 // reapplied when disabling screencasting.
3305 TEST_F(WebRtcVideoChannel2SimulcastTest, 3320 TEST_F(WebRtcVideoChannel2SimulcastTest,
3306 DISABLED_TwoTemporalLayerScreencastSettings) { 3321 DISABLED_TwoTemporalLayerScreencastSettings) {
3307 // TODO(pbos): Implement. 3322 // TODO(pbos): Implement.
3308 FAIL() << "Not implemented."; 3323 FAIL() << "Not implemented.";
3309 } 3324 }
3310 3325
3311 } // namespace cricket 3326 } // namespace cricket
OLDNEW

Powered by Google App Engine