Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1406903002: Expose codec implementation names in stats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 2355 matching lines...) Expand 10 before | Expand all | Expand 10 after
2366 parameters.codecs.push_back(kVp8Codec); 2366 parameters.codecs.push_back(kVp8Codec);
2367 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 2367 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2368 2368
2369 AddSendStream(); 2369 AddSendStream();
2370 2370
2371 cricket::VideoMediaInfo info; 2371 cricket::VideoMediaInfo info;
2372 ASSERT_TRUE(channel_->GetStats(&info)); 2372 ASSERT_TRUE(channel_->GetStats(&info));
2373 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name); 2373 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name);
2374 } 2374 }
2375 2375
2376 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsEncoderImplementationName) {
2377 FakeVideoSendStream* stream = AddSendStream();
2378 webrtc::VideoSendStream::Stats stats;
2379 stats.encoder_implementation_name = "encoder_implementation_name";
2380 stream->SetStats(stats);
2381
2382 cricket::VideoMediaInfo info;
2383 ASSERT_TRUE(channel_->GetStats(&info));
2384 EXPECT_EQ(stats.encoder_implementation_name,
2385 info.senders[0].encoder_implementation_name);
2386 }
2387
2376 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) { 2388 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) {
2377 FakeVideoSendStream* stream = AddSendStream(); 2389 FakeVideoSendStream* stream = AddSendStream();
2378 webrtc::VideoSendStream::Stats stats; 2390 webrtc::VideoSendStream::Stats stats;
2379 stats.avg_encode_time_ms = 13; 2391 stats.avg_encode_time_ms = 13;
2380 stats.encode_usage_percent = 42; 2392 stats.encode_usage_percent = 42;
2381 stream->SetStats(stats); 2393 stream->SetStats(stats);
2382 2394
2383 cricket::VideoMediaInfo info; 2395 cricket::VideoMediaInfo info;
2384 ASSERT_TRUE(channel_->GetStats(&info)); 2396 ASSERT_TRUE(channel_->GetStats(&info));
2385 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms); 2397 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
2517 info.receivers[0].firs_sent); 2529 info.receivers[0].firs_sent);
2518 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets, 2530 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
2519 info.receivers[0].nacks_sent); 2531 info.receivers[0].nacks_sent);
2520 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets, 2532 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
2521 info.receivers[0].plis_sent); 2533 info.receivers[0].plis_sent);
2522 } 2534 }
2523 2535
2524 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) { 2536 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) {
2525 FakeVideoReceiveStream* stream = AddRecvStream(); 2537 FakeVideoReceiveStream* stream = AddRecvStream();
2526 webrtc::VideoReceiveStream::Stats stats; 2538 webrtc::VideoReceiveStream::Stats stats;
2539 stats.decoder_implementation_name = "decoder_implementation_name";
2527 stats.decode_ms = 2; 2540 stats.decode_ms = 2;
2528 stats.max_decode_ms = 3; 2541 stats.max_decode_ms = 3;
2529 stats.current_delay_ms = 4; 2542 stats.current_delay_ms = 4;
2530 stats.target_delay_ms = 5; 2543 stats.target_delay_ms = 5;
2531 stats.jitter_buffer_ms = 6; 2544 stats.jitter_buffer_ms = 6;
2532 stats.min_playout_delay_ms = 7; 2545 stats.min_playout_delay_ms = 7;
2533 stats.render_delay_ms = 8; 2546 stats.render_delay_ms = 8;
2534 stream->SetStats(stats); 2547 stream->SetStats(stats);
2535 2548
2536 cricket::VideoMediaInfo info; 2549 cricket::VideoMediaInfo info;
2537 ASSERT_TRUE(channel_->GetStats(&info)); 2550 ASSERT_TRUE(channel_->GetStats(&info));
2551 EXPECT_EQ(stats.decoder_implementation_name,
2552 info.receivers[0].decoder_implementation_name);
2538 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms); 2553 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
2539 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms); 2554 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
2540 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms); 2555 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
2541 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms); 2556 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
2542 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms); 2557 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
2543 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms); 2558 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
2544 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms); 2559 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
2545 } 2560 }
2546 2561
2547 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) { 2562 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) {
(...skipping 686 matching lines...) Expand 10 before | Expand all | Expand 10 after
3234 // Ensures that the correct settings are applied to the codec when two temporal 3249 // Ensures that the correct settings are applied to the codec when two temporal
3235 // layer screencasting is enabled, and that the correct simulcast settings are 3250 // layer screencasting is enabled, and that the correct simulcast settings are
3236 // reapplied when disabling screencasting. 3251 // reapplied when disabling screencasting.
3237 TEST_F(WebRtcVideoChannel2SimulcastTest, 3252 TEST_F(WebRtcVideoChannel2SimulcastTest,
3238 DISABLED_TwoTemporalLayerScreencastSettings) { 3253 DISABLED_TwoTemporalLayerScreencastSettings) {
3239 // TODO(pbos): Implement. 3254 // TODO(pbos): Implement.
3240 FAIL() << "Not implemented."; 3255 FAIL() << "Not implemented.";
3241 } 3256 }
3242 3257
3243 } // namespace cricket 3258 } // namespace cricket
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698