Expose codec implementation names in stats.

webrtc/video/video_encoder.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 116 matching lines @@
     return fallback_encoder_->OnDroppedFrame();
   return encoder_->OnDroppedFrame();
 }
 
 bool VideoEncoderSoftwareFallbackWrapper::SupportsNativeHandle() const {
   if (fallback_encoder_)
     return fallback_encoder_->SupportsNativeHandle();
   return encoder_->SupportsNativeHandle();
 }
 
+const char* VideoEncoderSoftwareFallbackWrapper::ImplementationName() const {
+  if (fallback_encoder_)
+    return fallback_encoder_->ImplementationName();

[stefan-webrtc, 2015/10/16 07:47:03]

Should we add "fallback-" to the string here?

[pbos-webrtc, 2015/10/16 13:12:05]

Not unless we can know when an implementation is changed. I don't want to do any
string manipulation per frame. I added "software-fallback" since I think that's
more informative than "libvpx" when we've tried to do VP8 but failed.

[stefan-webrtc, 2015/10/22 09:33:34]

You don't have to manipulate the string for every frame. If you know you are
using the fallback encoder you should use the fallback encoder string, right? Or
do you mean that the fallback encoder implementation may change? In that case
maybe we should have a method to get the type of encoder so that we can check if
it has changed?

[pbos-webrtc, 2015/10/22 15:11:21]

Done, constructing the string once we start using the fallback encoder/decoder.

+  return encoder_->ImplementationName();
+}
+
 int VideoEncoderSoftwareFallbackWrapper::GetTargetFramerate() {
   if (fallback_encoder_)
     return fallback_encoder_->GetTargetFramerate();
   return encoder_->GetTargetFramerate();
 }
 
 }  // namespace webrtc