Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1406903002: Expose codec implementation names in stats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 2303 matching lines...) Expand 10 before | Expand all | Expand 10 after
2314 parameters.codecs.push_back(kVp8Codec); 2314 parameters.codecs.push_back(kVp8Codec);
2315 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 2315 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2316 2316
2317 AddSendStream(); 2317 AddSendStream();
2318 2318
2319 cricket::VideoMediaInfo info; 2319 cricket::VideoMediaInfo info;
2320 ASSERT_TRUE(channel_->GetStats(&info)); 2320 ASSERT_TRUE(channel_->GetStats(&info));
2321 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name); 2321 EXPECT_EQ(kVp8Codec.name, info.senders[0].codec_name);
2322 } 2322 }
2323 2323
2324 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsEncoderImplementationName) {
2325 FakeVideoSendStream* stream = AddSendStream();
2326 webrtc::VideoSendStream::Stats stats;
2327 stats.encoder_implementation_name = "decoder_implementation_name";
2328 stream->SetStats(stats);
2329
2330 cricket::VideoMediaInfo info;
2331 ASSERT_TRUE(channel_->GetStats(&info));
2332 EXPECT_EQ(stats.encoder_implementation_name,
2333 info.senders[0].encoder_implementation_name);
2334 }
2335
2324 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) { 2336 TEST_F(WebRtcVideoChannel2Test, GetStatsReportsCpuOveruseMetrics) {
2325 FakeVideoSendStream* stream = AddSendStream(); 2337 FakeVideoSendStream* stream = AddSendStream();
2326 webrtc::VideoSendStream::Stats stats; 2338 webrtc::VideoSendStream::Stats stats;
2327 stats.avg_encode_time_ms = 13; 2339 stats.avg_encode_time_ms = 13;
2328 stats.encode_usage_percent = 42; 2340 stats.encode_usage_percent = 42;
2329 stream->SetStats(stats); 2341 stream->SetStats(stats);
2330 2342
2331 cricket::VideoMediaInfo info; 2343 cricket::VideoMediaInfo info;
2332 ASSERT_TRUE(channel_->GetStats(&info)); 2344 ASSERT_TRUE(channel_->GetStats(&info));
2333 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms); 2345 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
2465 info.receivers[0].firs_sent); 2477 info.receivers[0].firs_sent);
2466 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets, 2478 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
2467 info.receivers[0].nacks_sent); 2479 info.receivers[0].nacks_sent);
2468 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets, 2480 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
2469 info.receivers[0].plis_sent); 2481 info.receivers[0].plis_sent);
2470 } 2482 }
2471 2483
2472 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) { 2484 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) {
2473 FakeVideoReceiveStream* stream = AddRecvStream(); 2485 FakeVideoReceiveStream* stream = AddRecvStream();
2474 webrtc::VideoReceiveStream::Stats stats; 2486 webrtc::VideoReceiveStream::Stats stats;
2487 stats.decoder_implementation_name = "decoder_implementation_name";
2475 stats.decode_ms = 2; 2488 stats.decode_ms = 2;
2476 stats.max_decode_ms = 3; 2489 stats.max_decode_ms = 3;
2477 stats.current_delay_ms = 4; 2490 stats.current_delay_ms = 4;
2478 stats.target_delay_ms = 5; 2491 stats.target_delay_ms = 5;
2479 stats.jitter_buffer_ms = 6; 2492 stats.jitter_buffer_ms = 6;
2480 stats.min_playout_delay_ms = 7; 2493 stats.min_playout_delay_ms = 7;
2481 stats.render_delay_ms = 8; 2494 stats.render_delay_ms = 8;
2482 stream->SetStats(stats); 2495 stream->SetStats(stats);
2483 2496
2484 cricket::VideoMediaInfo info; 2497 cricket::VideoMediaInfo info;
2485 ASSERT_TRUE(channel_->GetStats(&info)); 2498 ASSERT_TRUE(channel_->GetStats(&info));
2499 EXPECT_EQ(stats.decoder_implementation_name,
2500 info.receivers[0].decoder_implementation_name);
2486 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms); 2501 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
2487 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms); 2502 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
2488 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms); 2503 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
2489 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms); 2504 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
2490 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms); 2505 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
2491 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms); 2506 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
2492 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms); 2507 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
2493 } 2508 }
2494 2509
2495 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) { 2510 TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) {
(...skipping 697 matching lines...) Expand 10 before | Expand all | Expand 10 after
3193 // Ensures that the correct settings are applied to the codec when two temporal 3208 // Ensures that the correct settings are applied to the codec when two temporal
3194 // layer screencasting is enabled, and that the correct simulcast settings are 3209 // layer screencasting is enabled, and that the correct simulcast settings are
3195 // reapplied when disabling screencasting. 3210 // reapplied when disabling screencasting.
3196 TEST_F(WebRtcVideoChannel2SimulcastTest, 3211 TEST_F(WebRtcVideoChannel2SimulcastTest,
3197 DISABLED_TwoTemporalLayerScreencastSettings) { 3212 DISABLED_TwoTemporalLayerScreencastSettings) {
3198 // TODO(pbos): Implement. 3213 // TODO(pbos): Implement.
3199 FAIL() << "Not implemented."; 3214 FAIL() << "Not implemented.";
3200 } 3215 }
3201 3216
3202 } // namespace cricket 3217 } // namespace cricket
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698