Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: talk/app/webrtc/webrtcsdp_unittest.cc

Issue 1406803004: Fixing some issues with the direction attribute of m-lines in offers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing a comment. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/webrtcsdp_unittest.cc
diff --git a/talk/app/webrtc/webrtcsdp_unittest.cc b/talk/app/webrtc/webrtcsdp_unittest.cc
index de2ba2f479aab942ed72378dc0c060845c6184c7..cb6a392ab40bb3a99f46b4c3e52974e1452b2aa9 100644
--- a/talk/app/webrtc/webrtcsdp_unittest.cc
+++ b/talk/app/webrtc/webrtcsdp_unittest.cc
@@ -883,6 +883,9 @@ class WebRtcSdpTest : public testing::Test {
EXPECT_TRUE(CompareCandidates(transport1.description.candidates,
transport2.description.candidates));
}
+
+ // global attributes
+ EXPECT_EQ(desc1.msid_supported(), desc2.msid_supported());
}
bool CompareCandidates(const Candidates& cs1, const Candidates& cs2) {
@@ -1967,6 +1970,7 @@ TEST_F(WebRtcSdpTest, DeserializeSessionDescriptionWithRejectedAudioVideo) {
// Tests that we can still handle the sdp uses mslabel and label instead of
// msid for backward compatibility.
TEST_F(WebRtcSdpTest, DeserializeSessionDescriptionWithoutMsid) {
+ jdesc_.description()->set_msid_supported(false);
JsepSessionDescription jdesc(kDummyString);
std::string sdp_without_msid = kSdpFullString;
Replace("msid", "xmsid", &sdp_without_msid);

Powered by Google App Engine
This is Rietveld 408576698