Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1406223011: Relax the stun ping check on valid result (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relax the stun ping check on valid result. 1. allow situation where all ping is lost 2. use the raw count to calculate the interval. Since we now send 1 request per IP, the chance of losing all of them is higher and we shouldn't just quit if we don't have any response. BUG= Committed: https://crrev.com/066ded99cbdb2e110116335bf604709b21ef25a9 Cr-Commit-Position: refs/heads/master@{#10613}

Patch Set 1 #

Patch Set 2 : fix a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M webrtc/p2p/stunprober/stunprober.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.cc View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
guoweis_webrtc
+sergeyu
5 years, 1 month ago (2015-11-04 23:28:03 UTC) #5
pthatcher1
lgtm
5 years, 1 month ago (2015-11-11 20:01:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406223011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406223011/20001
5 years, 1 month ago (2015-11-11 21:57:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-11 23:04:11 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 23:04:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/066ded99cbdb2e110116335bf604709b21ef25a9
Cr-Commit-Position: refs/heads/master@{#10613}

Powered by Google App Engine
This is Rietveld 408576698