webrtc/voice_engine/channel.cc - Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel.cc

Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: review fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/voice_engine/channel.cc

diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc

index 65cf7a691005cdf046741c694b45fd5462df3467..ed47b57fa81ceb7cbc0cc63e1d28995b245ed682 100644

--- a/webrtc/voice_engine/channel.cc

+++ b/webrtc/voice_engine/channel.cc

@@ -1242,7 +1242,12 @@ Channel::DeRegisterVoiceEngineObserver()

int32_t

Channel::GetSendCodec(CodecInst& codec)

{

- return (audio_coding_->SendCodec(&codec));

+ auto send_codec = audio_coding_->SendCodec();

+ if (send_codec) {

+ codec = *send_codec;

+ return 0;

+ }

+ return -1;

}

int32_t

« no previous file with comments | « webrtc/modules/audio_coding/main/test/iSACTest.cc ('k') | no next file » | no next file with comments »