webrtc/modules/audio_coding/main/acm2/codec_manager.h - Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/codec_manager.h

Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: review fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc ('k') | webrtc/modules/audio_coding/main/acm2/codec_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/codec_manager.h

diff --git a/webrtc/modules/audio_coding/main/acm2/codec_manager.h b/webrtc/modules/audio_coding/main/acm2/codec_manager.h

index c6c262ea266fa6b94d1d56afab37a4139d6661d2..26b5a2802ecbe7558bf114dd5e7091f2dcd5f48a 100644

--- a/webrtc/modules/audio_coding/main/acm2/codec_manager.h

+++ b/webrtc/modules/audio_coding/main/acm2/codec_manager.h

@@ -12,6 +12,7 @@

#define WEBRTC_MODULES_AUDIO_CODING_MAIN_ACM2_CODEC_MANAGER_H_

#include "webrtc/base/constructormagic.h"

+#include "webrtc/base/maybe.h"

#include "webrtc/base/scoped_ptr.h"

#include "webrtc/base/thread_checker.h"

#include "webrtc/modules/audio_coding/main/acm2/codec_owner.h"

@@ -34,7 +35,7 @@ class CodecManager final {

void RegisterEncoder(AudioEncoder* external_speech_encoder);

- int GetCodecInst(CodecInst* current_codec) const;

+ rtc::Maybe<CodecInst> GetCodecInst() const;

bool SetCopyRed(bool enable);