webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc - Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

Issue 1406123011: Let AudioCodingModule::SendCodec return Maybe<CodecInst> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: review fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h ('k') | webrtc/modules/audio_coding/main/acm2/codec_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

index dfd777c7ad0be3e521ed8ef074cc26b38ff87c54..8f2d6f2a8266405e2ae53a63104a59f0763a360f 100644

--- a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

+++ b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc

@@ -206,9 +206,9 @@ void AudioCodingModuleImpl::RegisterExternalSendCodec(

}

// Get current send codec.

-int AudioCodingModuleImpl::SendCodec(CodecInst* current_codec) const {

+rtc::Maybe<CodecInst> AudioCodingModuleImpl::SendCodec() const {

CriticalSectionScoped lock(acm_crit_sect_.get());

- return codec_manager_.GetCodecInst(current_codec);

+ return codec_manager_.GetCodecInst();

}

// Get current send frequency.