Let AudioCodingModule::SendCodec return Maybe<CodecInst>

webrtc/voice_engine/channel.cc

Index: webrtc/voice_engine/channel.cc
diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc
index 65cf7a691005cdf046741c694b45fd5462df3467..98c130fee196757f98366683f6ad566345cac629 100644
--- a/webrtc/voice_engine/channel.cc
+++ b/webrtc/voice_engine/channel.cc
@@ -1242,7 +1242,10 @@ Channel::DeRegisterVoiceEngineObserver()
 int32_t
 Channel::GetSendCodec(CodecInst& codec)
 {
-    return (audio_coding_->SendCodec(&codec));
+    auto send_codec = audio_coding_->SendCodec();
+    if (send_codec)
+        codec = *send_codec;

[the sun, 2015/11/03 10:13:42]

nit: less indent + braxies

[kwiberg-webrtc, 2015/11/03 12:23:53]

I was trying to keep with the style of the rest of the file. Couldn't bring
myself to imitate the brace style it's using, though, so I picked an acceptable
alternative.

Would you prefer clang-format-compatible formatting instead?

[the sun, 2015/11/03 12:38:21]

just fix the indent, but this function would read better as:

auto send_codec = audio_coding_->SendCodec();
if (send_codec) {
  codec = *send_codec;
  return 0;
}
return -1;

No need to repeat the condition

[kwiberg-webrtc, 2015/11/03 13:08:19]

Done.

+    return send_codec ? 0 : -1;
 }
 
 int32_t