Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1405103006: Fix flaky tests (Closed)

Created:
5 years, 1 month ago by honghaiz3
Modified:
5 years, 1 month ago
Reviewers:
pthatcher, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pbos-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix flaky tests BUG=webrtc:5190, webrtc:5136 Committed: https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6 Cr-Commit-Position: refs/heads/master@{#10639}

Patch Set 1 #

Patch Set 2 : re-formatting #

Total comments: 2

Patch Set 3 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 2 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
honghaiz3
5 years, 1 month ago (2015-11-10 21:25:58 UTC) #3
pthatcher
lgtm https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransportchannel_unittest.cc File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right): https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransportchannel_unittest.cc#newcode1544 webrtc/p2p/base/p2ptransportchannel_unittest.cc:1544: 1000, 1000); Did you run "git cl format"?
5 years, 1 month ago (2015-11-12 19:35:20 UTC) #6
honghaiz3
https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransportchannel_unittest.cc File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right): https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransportchannel_unittest.cc#newcode1544 webrtc/p2p/base/p2ptransportchannel_unittest.cc:1544: 1000, 1000); On 2015/11/12 19:35:20, pthatcher wrote: > Did ...
5 years, 1 month ago (2015-11-12 19:38:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103006/40001
5 years, 1 month ago (2015-11-12 19:46:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1717)
5 years, 1 month ago (2015-11-12 19:51:11 UTC) #12
honghaiz3
This needs a lgtm from your webrtc account.
5 years, 1 month ago (2015-11-12 21:21:04 UTC) #13
pthatcher1
lgtm
5 years, 1 month ago (2015-11-13 01:46:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103006/40001
5 years, 1 month ago (2015-11-13 17:45:49 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-13 17:52:59 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6 Cr-Commit-Position: refs/heads/master@{#10639}
5 years, 1 month ago (2015-11-13 17:53:09 UTC) #18
tommi
On 2015/11/13 at 17:53:09, commit-bot wrote: > Patchset 3 (id:??) landed as https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6 > Cr-Commit-Position: ...
5 years, 1 month ago (2015-11-16 12:27:28 UTC) #19
honghaiz3
5 years, 1 month ago (2015-11-16 20:48:59 UTC) #20
Message was sent while issue was closed.
On 2015/11/16 12:27:28, tommi (webrtc) wrote:
> On 2015/11/13 at 17:53:09, commit-bot wrote:
> > Patchset 3 (id:??) landed as
> https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6
> > Cr-Commit-Position: refs/heads/master@{#10639}
> 
> drive by nit: It would be good if the description is more specific.  List what
> tests, test suites or area that the tests cover.  That way the commit log is a
> lot easier to parse and search.
Will make it more specific in the future.

Powered by Google App Engine
This is Rietveld 408576698