|
|
DescriptionFix flaky tests
BUG=webrtc:5190, webrtc:5136
Committed: https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6
Cr-Commit-Position: refs/heads/master@{#10639}
Patch Set 1 #Patch Set 2 : re-formatting #
Total comments: 2
Patch Set 3 : Merge to head #Messages
Total messages: 20 (8 generated)
Description was changed from ========== Fix flaky tests BUG= ========== to ========== Fix flaky tests BUG=webrtc:5190 ==========
honghaiz@webrtc.org changed reviewers: + pthatcher@webrtc.org
Description was changed from ========== Fix flaky tests BUG=webrtc:5190 ========== to ========== Fix flaky tests BUG=webrtc:5190,webrtc:5136 ==========
pthatcher@google.com changed reviewers: + pthatcher@google.com
lgtm https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransp... File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right): https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransp... webrtc/p2p/base/p2ptransportchannel_unittest.cc:1544: 1000, 1000); Did you run "git cl format"?
https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransp... File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right): https://codereview.webrtc.org/1405103006/diff/20001/webrtc/p2p/base/p2ptransp... webrtc/p2p/base/p2ptransportchannel_unittest.cc:1544: 1000, 1000); On 2015/11/12 19:35:20, pthatcher wrote: > Did you run "git cl format"? This is the result from that.
The CQ bit was checked by honghaiz@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@google.com Link to the patchset: https://codereview.webrtc.org/1405103006/#ps40001 (title: "Merge to head")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103006/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1717)
This needs a lgtm from your webrtc account.
lgtm
The CQ bit was checked by honghaiz@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405103006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405103006/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6 Cr-Commit-Position: refs/heads/master@{#10639}
Message was sent while issue was closed.
On 2015/11/13 at 17:53:09, commit-bot wrote: > Patchset 3 (id:??) landed as https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6 > Cr-Commit-Position: refs/heads/master@{#10639} drive by nit: It would be good if the description is more specific. List what tests, test suites or area that the tests cover. That way the commit log is a lot easier to parse and search.
Message was sent while issue was closed.
On 2015/11/16 12:27:28, tommi (webrtc) wrote: > On 2015/11/13 at 17:53:09, commit-bot wrote: > > Patchset 3 (id:??) landed as > https://crrev.com/a4845efe14f14c30d2697265af68c9c1b8893ac6 > > Cr-Commit-Position: refs/heads/master@{#10639} > > drive by nit: It would be good if the description is more specific. List what > tests, test suites or area that the tests cover. That way the commit log is a > lot easier to parse and search. Will make it more specific in the future. |