Convert usage of ARRAY_SIZE to arraysize.

Convert usage of ARRAY_SIZE to arraysize.

ARRAY_SIZE is the old version of arraysize and does not cover
all the cases in C++, arraysize is a copy of Chromium's
version and thus have wider coverage.

BUG=None
R=tommi@webrtc.org

Committed: https://crrev.com/5237aaf243d29732f59557361b7a993c0a18cf0e
Cr-Commit-Position: refs/heads/master@{#10594}

[tfarina, 2015-11-06 00:15:01]

Description was changed from

==========
ARRAY_SIZE -> arraysize. WIP

BUG=None
R=tommi@webrtc.org
==========

to

==========
Convert usage of ARRAY_SIZE to arraysize.

ARRAY_SIZE is the old version of arraysize and does not cover all the cases in
C++, arraysize is a copy of Chromium's version and thus have wider coverage.

BUG=None
R=tommi@webrtc.org
==========

[tfarina, 2015-11-06 00:15:30]

Description was changed from

==========
Convert usage of ARRAY_SIZE to arraysize.

ARRAY_SIZE is the old version of arraysize and does not cover all the cases in
C++, arraysize is a copy of Chromium's version and thus have wider coverage.

BUG=None
R=tommi@webrtc.org
==========

to

==========
Convert usage of ARRAY_SIZE to arraysize.

ARRAY_SIZE is the old version of arraysize and does not cover
all the cases in C++, arraysize is a copy of Chromium's
version and thus have wider coverage.

BUG=None
R=tommi@webrtc.org
==========

[tfarina, 2015-11-06 13:32:14]

Hey Tomas! Could you please take a look at this.

Let me know if I should split this in smaller changes.

I plan to remove basicdefs.h in a followup CL.

[tommi (sloooow) - chröme, 2015-11-06 22:33:24]

tommi@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2015-11-06 22:33:25]

lgtm with the casts fixed.  thanks for doing this! :)

https://codereview.chromium.org/1405023016/diff/290001/talk/media/webrtc/webr...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.chromium.org/1405023016/diff/290001/talk/media/webrtc/webr...
talk/media/webrtc/webrtcvoiceengine.cc:471: (int)arraysize(kCodecPrefs) - (pref
- kCodecPrefs));
use static_cast

https://codereview.chromium.org/1405023016/diff/290001/webrtc/base/physicalso...
File webrtc/base/physicalsocketserver.cc (right):

https://codereview.chromium.org/1405023016/diff/290001/webrtc/base/physicalso...
webrtc/base/physicalsocketserver.cc:632: ASSERT(signum <
(int)arraysize(received_signal_));
static_cast here and elsewhere

[tfarina, 2015-11-10 23:02:45]

https://codereview.chromium.org/1405023016/diff/290001/talk/media/webrtc/webr...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.chromium.org/1405023016/diff/290001/talk/media/webrtc/webr...
talk/media/webrtc/webrtcvoiceengine.cc:471: (int)arraysize(kCodecPrefs) - (pref
- kCodecPrefs));
On 2015/11/06 22:33:25, tommi wrote:
> use static_cast

Done.

https://codereview.chromium.org/1405023016/diff/290001/webrtc/base/physicalso...
File webrtc/base/physicalsocketserver.cc (right):

https://codereview.chromium.org/1405023016/diff/290001/webrtc/base/physicalso...
webrtc/base/physicalsocketserver.cc:632: ASSERT(signum <
(int)arraysize(received_signal_));
On 2015/11/06 22:33:25, tommi wrote:
> static_cast here and elsewhere

Done.

[tfarina, 2015-11-10 23:03:04]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-11-10 23:03:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.webrtc.org/1405023016/#ps310001 (title:
"static_cast<int>")

[commit-bot: I haz the power, 2015-11-10 23:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405023016/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405023016/310001

[commit-bot: I haz the power, 2015-11-10 23:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 23:03:25]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tommi, 2015-11-10 23:09:11]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2015-11-10 23:09:12]

lgtm

[commit-bot: I haz the power, 2015-11-10 23:09:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405023016/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405023016/310001

[commit-bot: I haz the power, 2015-11-11 01:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 01:09:37]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tommi, 2015-11-11 07:39:07]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2015-11-11 07:39:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405023016/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405023016/310001

[commit-bot: I haz the power, 2015-11-11 07:44:35]

Committed patchset #17 (id:310001)

[commit-bot: I haz the power, 2015-11-11 07:44:52]

Patchset 17 (id:??) landed as
https://crrev.com/5237aaf243d29732f59557361b7a993c0a18cf0e
Cr-Commit-Position: refs/heads/master@{#10594}