Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: webrtc/video/send_statistics_proxy.cc

Issue 1405023014: Add histograms for send-side delay stats for a sent video stream: (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/send_statistics_proxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/send_statistics_proxy.cc
diff --git a/webrtc/video/send_statistics_proxy.cc b/webrtc/video/send_statistics_proxy.cc
index 5be9970583a68205fabffc89f621a997b4e86b7f..916ffb3baa4bfbdd9745ea90c90933bb4405b5ea 100644
--- a/webrtc/video/send_statistics_proxy.cc
+++ b/webrtc/video/send_statistics_proxy.cc
@@ -121,6 +121,15 @@ void SendStatisticsProxy::UpdateHistograms() {
RTC_HISTOGRAM_ENUMERATION(
"WebRTC.Video.BandwidthLimitedResolutionsDisabled", num_disabled, 10);
}
+ int delay_ms = delay_counter_.Avg(kMinRequiredSamples);
+ if (delay_ms != -1)
+ RTC_HISTOGRAM_COUNTS_100000("WebRTC.Video.SendSideDelayInMs", delay_ms);
+
+ int max_delay_ms = max_delay_counter_.Avg(kMinRequiredSamples);
+ if (max_delay_ms != -1) {
+ RTC_HISTOGRAM_COUNTS_100000(
+ "WebRTC.Video.SendSideDelayMaxInMs", max_delay_ms);
+ }
}
void SendStatisticsProxy::OnOutgoingRate(uint32_t framerate, uint32_t bitrate) {
@@ -337,6 +346,9 @@ void SendStatisticsProxy::SendSideDelayUpdated(int avg_delay_ms,
return;
stats->avg_delay_ms = avg_delay_ms;
stats->max_delay_ms = max_delay_ms;
+
+ delay_counter_.Add(avg_delay_ms);
+ max_delay_counter_.Add(max_delay_ms);
}
void SendStatisticsProxy::SampleCounter::Add(int sample) {
« no previous file with comments | « webrtc/video/send_statistics_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698