Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: webrtc/modules/audio_processing/echo_control_mobile_impl.cc

Issue 1404743003: Removed the indirect error message reporting in aec and aecm. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@process_test_no_output_CL
Patch Set: Removed obsolete comments and reverted the changes in processing_component.cc as they were not need… Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/echo_control_mobile_impl.cc
diff --git a/webrtc/modules/audio_processing/echo_control_mobile_impl.cc b/webrtc/modules/audio_processing/echo_control_mobile_impl.cc
index 8d5ec9c4e296371672cefe50c4035a153280cd68..d0161e0b4644fa91911b338835e915e5aa6f7d11 100644
--- a/webrtc/modules/audio_processing/echo_control_mobile_impl.cc
+++ b/webrtc/modules/audio_processing/echo_control_mobile_impl.cc
@@ -40,22 +40,6 @@ int16_t MapSetting(EchoControlMobile::RoutingMode mode) {
return -1;
}
-AudioProcessing::Error MapError(int err) {
- switch (err) {
- case AECM_UNSUPPORTED_FUNCTION_ERROR:
- return AudioProcessing::kUnsupportedFunctionError;
- case AECM_NULL_POINTER_ERROR:
- return AudioProcessing::kNullPointerError;
- case AECM_BAD_PARAMETER_ERROR:
- return AudioProcessing::kBadParameterError;
- case AECM_BAD_PARAMETER_WARNING:
- return AudioProcessing::kBadStreamParameterWarning;
- default:
- // AECM_UNSPECIFIED_ERROR
- // AECM_UNINITIALIZED_ERROR
- return AudioProcessing::kUnspecifiedError;
- }
-}
} // namespace
size_t EchoControlMobile::echo_path_size_bytes() {
@@ -289,6 +273,6 @@ int EchoControlMobileImpl::num_handles_required() const {
int EchoControlMobileImpl::GetHandleError(void* handle) const {
assert(handle != NULL);
- return MapError(WebRtcAecm_get_error_code(static_cast<Handle*>(handle)));
+ return AudioProcessing::kUnspecifiedError;
}
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698