Removed the indirect error message reporting in aec and aecm.

webrtc/modules/audio_processing/aec/include/echo_cancellation.h

Index: webrtc/modules/audio_processing/aec/include/echo_cancellation.h
diff --git a/webrtc/modules/audio_processing/aec/include/echo_cancellation.h b/webrtc/modules/audio_processing/aec/include/echo_cancellation.h
index a340cf84d0d79f13b3658bf142817cf6f92576cf..3b82a3596e26d3d6fac3ccefa32eddfb25cda238 100644
--- a/webrtc/modules/audio_processing/aec/include/echo_cancellation.h
+++ b/webrtc/modules/audio_processing/aec/include/echo_cancellation.h
@@ -109,13 +109,32 @@ int32_t WebRtcAec_Init(void* aecInst, int32_t sampFreq, int32_t scSampFreq);
  * Outputs                      Description
  * -------------------------------------------------------------------
  * int32_t        return        0: OK
- *                             -1: error
+ * int32_t        return        12000-12050: error code

[Andrew MacDonald, 2015/10/16 06:05:09]

It's a pretty strong convention in webrtc that error returns are less than zero.
Do you want to keep the error codes at all? If so, I'd make them proceed
downward from -1.

The notion that they had to occupy a unique range is completely legacy, so don't
worry about that.

Should we just remove them entirely though, and return -1?

[peah-webrtc, 2015/10/16 08:14:39]

That would be great! We've had discussions about the error codes, the how useful
they are, and how it would be possible to react on them.

If ok, I won't fix this in the scope of the current work, but I'd be happy to
change it afterwards.

[Andrew MacDonald, 2015/10/16 15:47:05]

That's fine. I think if you intend to remove them you can leave the codes as-is,
but if you decide to keep them it would be great if you could change them to be
non-unique and descending from -1 in a soon-ish CL. Thanks!

[peah-webrtc, 2015/10/23 09:31:15]

Acknowledged.

  */
 int32_t WebRtcAec_BufferFarend(void* aecInst,
                                const float* farend,
                                size_t nrOfSamples);
 
 /*
+ * Reports any errors that would arise if buffering a farend buffer
+ *
+ * Inputs                       Description
+ * -------------------------------------------------------------------
+ * void*          aecInst       Pointer to the AEC instance
+ * const float*   farend        In buffer containing one frame of
+ *                              farend signal for L band
+ * int16_t        nrOfSamples   Number of samples in farend buffer
+ *
+ * Outputs                      Description
+ * -------------------------------------------------------------------
+ * int32_t        return        0: OK
+ * int32_t        return        12000-12050: error code
+ */
+int32_t WebRtcAec_GetBufferFarendError(void* aecInst,
+                                       const float* farend,
+                                       size_t nrOfSamples);
+
+/*
  * Runs the echo canceller on an 80 or 160 sample blocks of data.
  *
  * Inputs                       Description
@@ -136,7 +155,7 @@ int32_t WebRtcAec_BufferFarend(void* aecInst,
  * float* const* out            Out buffer, one frame of processed nearend
  *                              for each band
  * int32_t       return         0: OK
- *                             -1: error
+ * int32_t        return        12000-12050: error code
  */
 int32_t WebRtcAec_Process(void* aecInst,
                           const float* const* nearend,
@@ -158,7 +177,7 @@ int32_t WebRtcAec_Process(void* aecInst,
  * Outputs                      Description
  * -------------------------------------------------------------------
  * int            return         0: OK
- *                              -1: error
+ * int32_t        return        12000-12050: error code
  */
 int WebRtcAec_set_config(void* handle, AecConfig config);
 
@@ -174,7 +193,7 @@ int WebRtcAec_set_config(void* handle, AecConfig config);
  * int*           status        0: Almost certainly nearend single-talk
  *                              1: Might not be neared single-talk
  * int            return         0: OK
- *                              -1: error
+ * int32_t        return        12000-12050: error code
  */
 int WebRtcAec_get_echo_status(void* handle, int* status);
 
@@ -190,7 +209,7 @@ int WebRtcAec_get_echo_status(void* handle, int* status);
  * AecMetrics*    metrics       Struct which will be filled out with the
  *                              current echo metrics.
  * int            return         0: OK
- *                              -1: error
+ * int32_t        return        12000-12050: error code
  */
 int WebRtcAec_GetMetrics(void* handle, AecMetrics* metrics);
 
@@ -209,26 +228,13 @@ int WebRtcAec_GetMetrics(void* handle, AecMetrics* metrics);
  *                              cause the AEC to perform poorly.
  *
  * int     return                0: OK
- *                              -1: error
+ * int32_t        return        12000-12050: error code
  */
 int WebRtcAec_GetDelayMetrics(void* handle,
                               int* median,
                               int* std,
                               float* fraction_poor_delays);
 
-/*
- * Gets the last error code.
- *
- * Inputs                       Description
- * -------------------------------------------------------------------
- * void*          aecInst       Pointer to the AEC instance
- *
- * Outputs                      Description
- * -------------------------------------------------------------------
- * int32_t        return        11000-11100: error code
- */
-int32_t WebRtcAec_get_error_code(void* aecInst);
-
 // Returns a pointer to the low level AEC handle.
 //
 // Input: