Update receive report SSRCs on RemoveSendStream.

Update receive report SSRCs on RemoveSendStream.

Prevents RTCP receiver reports, including PLIs with an old
receiver-report SSRC, from being dropped from the remote sender's
BundleFilter due to no longer being in use.

BUG=chromium:523928, webrtc:4883
R=stefan@webrtc.org

Committed: https://crrev.com/dfa2815b4f606a58ede5c0214e08a1d5d26d3639
Cr-Commit-Position: refs/heads/master@{#10359}

[pbos-webrtc, 2015-10-19 18:39:42]

PTAL, eep. :|

[pbos-webrtc, 2015-10-19 18:41:35]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 18:41:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404363003/1

[commit-bot: I haz the power, 2015-10-19 21:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 21:06:30]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2015-10-21 14:03:12]

How about adding a higher level test which verifies video actually works after
renegotiation? That would be less specific to and would cover more situations.

[pbos-webrtc, 2015-10-21 14:13:47]

On 2015/10/21 14:03:12, stefan-webrtc (holmer) wrote:
> How about adding a higher level test which verifies video actually works after
> renegotiation? That would be less specific to and would cover more situations.

I'm not sure how to test this to not make it too specific to only catching this
bug (which is covered by the correct-SSRC test). If so it needs to be on the
browser level or at least below this, since BundleFilter doesn't kick in in the
engine tests, even the ones that test that we receive video.

[stefan-webrtc, 2015-10-21 14:44:20]

On 2015/10/21 14:13:47, pbos-webrtc wrote:
> On 2015/10/21 14:03:12, stefan-webrtc (holmer) wrote:
> > How about adding a higher level test which verifies video actually works
after
> > renegotiation? That would be less specific to and would cover more
situations.
> 
> I'm not sure how to test this to not make it too specific to only catching
this
> bug (which is covered by the correct-SSRC test). If so it needs to be on the
> browser level or at least below this, since BundleFilter doesn't kick in in
the
> engine tests, even the ones that test that we receive video.

A browser test would have been nice, but those are in chromium, so not in this
CL. If feel like it you could look into it.

LGTM

[pbos-webrtc, 2015-10-21 15:08:35]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-10-21 15:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404363003/1

[pbos-webrtc, 2015-10-21 15:21:27]

Committed patchset #1 (id:1) manually as
dfa2815b4f606a58ede5c0214e08a1d5d26d3639 (presubmit successful).

[commit-bot: I haz the power, 2015-10-21 15:21:31]

Patchset 1 (id:??) landed as
https://crrev.com/dfa2815b4f606a58ede5c0214e08a1d5d26d3639
Cr-Commit-Position: refs/heads/master@{#10359}