Roll chromium_revision c089d37..159828f (353662:353696) + fix GN

build_overrides/webrtc.gni

+# Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+#
+# Use of this source code is governed by a BSD-style license
+# that can be found in the LICENSE file in the root of the source
+# tree. An additional intellectual property rights grant can be found
+# in the file PATENTS.  All contributing project authors may
+# be found in the AUTHORS file in the root of the source tree.
+
+# This file contains overrides to GN variables that applies for the WebRTC
+# standalone build (i.e. not in Chromium).
+#
+# Every variable here needs to be present in the corresponding file in
+# build_overrides/ of Chromium.
+
+build_with_chromium = false
+
+# TODO(andrew): For now, disable the Chrome plugins, which causes a

[kjellander_webrtc, 2015/10/13 16:38:18]

dpranke: It seems I need to move all these variables here (not just
build_with_chromium).

If I don't move clang_use_chrome_plugins, I get this when I run gn gen:

ERROR at //build/config/clang/clang.gni:8:30: Duplicate build argument
declaration.
  clang_use_chrome_plugins = is_clang && !is_nacl
                             ^-------------------
Here you're declaring an argument that was already declared elsewhere.
You can only declare each argument once in the entire build so there is one
canonical place for documentation and the default value. Either move this
argument to the build config file (for visibility everywhere) or to a .gni file
that you "import" from the files where you need it (preferred).
See //webrtc/build/webrtc.gni:75:32: Previous declaration.
    clang_use_chrome_plugins = false
                               ^----
See also "gn help buildargs" for more on how build arguments work.

[Dirk Pranke, 2015/10/13 17:40:34]

From just looking at the CL, I'm not quite sure what all is going on. I can see
how clang_use_chrome_plugins might be an issue, but I'm not sure about the
others. I will take a closer look when I'm in front of a webrtc checkout later
this morning.

+# flood of chromium-style warnings. Investigate enabling them:
+# http://code.google.com/p/webrtc/issues/detail?id=163
+clang_use_chrome_plugins = false
+
+# Excluded in Chromium since its prerequisites don't require Pulse Audio.
+rtc_include_pulse_audio = true
+
+# Chromium uses its own IO handling, so the internal ADM is only built for
+# standalone WebRTC.
+rtc_include_internal_audio_device = true