Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: webrtc/call.h

Issue 1403363003: Move VoiceEngineObserver into AudioSendStream so that we detect typing noises and return properly i… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: that's all folks! (incl rebase), or is it? Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/audio_state.h ('k') | webrtc/call/bitrate_estimator_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call.h
diff --git a/webrtc/call.h b/webrtc/call.h
index e6e8cdee0bd35461e71c40dfbe9a780ba2ccb8d4..313c5e58c16f49446c8d6fbcdaa92950179628a8 100644
--- a/webrtc/call.h
+++ b/webrtc/call.h
@@ -16,16 +16,14 @@
#include "webrtc/common_types.h"
#include "webrtc/audio_receive_stream.h"
#include "webrtc/audio_send_stream.h"
+#include "webrtc/audio_state.h"
#include "webrtc/base/socket.h"
#include "webrtc/video_receive_stream.h"
#include "webrtc/video_send_stream.h"
namespace webrtc {
-class AudioDeviceModule;
class AudioProcessing;
-class VoiceEngine;
-class VoiceEngineObserver;
const char* Version();
@@ -74,9 +72,6 @@ class Call {
struct Config {
static const int kDefaultStartBitrateBps;
- // VoiceEngine used for audio/video synchronization for this Call.
- VoiceEngine* voice_engine = nullptr;
-
// Bitrate config used until valid bitrate estimates are calculated. Also
// used to cap total bitrate used.
struct BitrateConfig {
@@ -85,11 +80,13 @@ class Call {
int max_bitrate_bps = -1;
} bitrate_config;
- struct AudioConfig {
- AudioDeviceModule* audio_device_module = nullptr;
- AudioProcessing* audio_processing = nullptr;
- VoiceEngineObserver* voice_engine_observer = nullptr;
- } audio_config;
+ // AudioState which is possibly shared between multiple calls.
+ // TODO(solenberg): Change this to a shared_ptr once we can use C++11.
+ rtc::scoped_refptr<AudioState> audio_state;
+
+ // Audio Processing Module to be used in this call.
+ // TODO(solenberg): Change this to a shared_ptr once we can use C++11.
+ AudioProcessing* audio_processing = nullptr;
};
struct Stats {
« no previous file with comments | « webrtc/audio_state.h ('k') | webrtc/call/bitrate_estimator_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698