Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1403353003: Added thread checker to webrtc::Call. (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
tommi, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@call_send_stream
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added thread checker to webrtc::Call. BUG= Committed: https://crrev.com/5a289393928c18af580c6339ba77600fb67006e2 Cr-Commit-Position: refs/heads/master@{#10321}

Patch Set 1 #

Patch Set 2 : missed one #

Total comments: 3

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M webrtc/call/call.cc View 1 2 3 17 chunks +28 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (3 generated)
the sun
5 years, 2 months ago (2015-10-16 09:16:45 UTC) #2
the sun
5 years, 2 months ago (2015-10-16 09:43:04 UTC) #3
tommi
lgtm thanks
5 years, 2 months ago (2015-10-16 11:16:49 UTC) #4
pbos-webrtc
won't block, lgtm https://codereview.webrtc.org/1403353003/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/1403353003/diff/20001/webrtc/call/call.cc#newcode446 webrtc/call/call.cc:446: RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); (I think this should also ...
5 years, 2 months ago (2015-10-16 12:58:59 UTC) #5
the sun
https://codereview.webrtc.org/1403353003/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/1403353003/diff/20001/webrtc/call/call.cc#newcode446 webrtc/call/call.cc:446: RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); On 2015/10/16 12:58:59, pbos-webrtc wrote: > (I think ...
5 years, 2 months ago (2015-10-19 07:55:43 UTC) #6
pbos-webrtc
On 2015/10/19 07:55:43, the sun wrote: > https://codereview.webrtc.org/1403353003/diff/20001/webrtc/call/call.cc > File webrtc/call/call.cc (right): > > https://codereview.webrtc.org/1403353003/diff/20001/webrtc/call/call.cc#newcode446 ...
5 years, 2 months ago (2015-10-19 08:40:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403353003/60001
5 years, 2 months ago (2015-10-19 10:36:44 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-19 10:39:23 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 10:39:35 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5a289393928c18af580c6339ba77600fb67006e2
Cr-Commit-Position: refs/heads/master@{#10321}

Powered by Google App Engine
This is Rietveld 408576698