Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1403173002: Don't create remote streams if m-line direction doesn't include "send". (Closed)

Created:
5 years, 2 months ago by Taylor Brandstetter
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't create remote streams if m-line direction doesn't include "send". BUG=webrtc:5054 Committed: https://crrev.com/5e97fb5c996743a4c137a5279be6eb6485225b65 Cr-Commit-Position: refs/heads/master@{#10293}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding "GetActiveStreams" helper method. #

Patch Set 3 : Formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
M talk/app/webrtc/peerconnection.cc View 1 2 4 chunks +15 lines, -5 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 10 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Taylor Brandstetter
5 years, 2 months ago (2015-10-15 00:53:48 UTC) #2
pthatcher1
lgtm https://codereview.webrtc.org/1403173002/diff/1/talk/app/webrtc/peerconnection.cc File talk/app/webrtc/peerconnection.cc (right): https://codereview.webrtc.org/1403173002/diff/1/talk/app/webrtc/peerconnection.cc#newcode1037 talk/app/webrtc/peerconnection.cc:1037: : std::vector<cricket::StreamParams>(), Can you put this logic in ...
5 years, 2 months ago (2015-10-15 05:46:49 UTC) #3
Taylor Brandstetter
https://codereview.webrtc.org/1403173002/diff/1/talk/app/webrtc/peerconnection.cc File talk/app/webrtc/peerconnection.cc (right): https://codereview.webrtc.org/1403173002/diff/1/talk/app/webrtc/peerconnection.cc#newcode1037 talk/app/webrtc/peerconnection.cc:1037: : std::vector<cricket::StreamParams>(), On 2015/10/15 05:46:49, pthatcher1 wrote: > Can ...
5 years, 2 months ago (2015-10-15 17:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403173002/40001
5 years, 2 months ago (2015-10-15 19:48:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-15 19:49:13 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 19:49:19 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5e97fb5c996743a4c137a5279be6eb6485225b65
Cr-Commit-Position: refs/heads/master@{#10293}

Powered by Google App Engine
This is Rietveld 408576698