Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1402403008: Changed FakeVoiceEngine into a MockVoiceEngine. (Closed)

Created:
5 years, 1 month ago by the sun
Modified:
5 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed FakeVoiceEngine into a MockVoiceEngine. BUG=webrtc:4690 R=tommi@webrtc.org Committed: https://crrev.com/0ccae135562ac180da053fcecda91a0365621f14 Cr-Commit-Position: refs/heads/master@{#10491}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : unneeded include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -699 lines) Patch
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 3 chunks +93 lines, -51 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +79 lines, -29 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 7 chunks +12 lines, -17 lines 0 comments Download
M webrtc/call/call_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/test/fake_voice_engine.h View 1 chunk +0 lines, -503 lines 0 comments Download
D webrtc/test/fake_voice_engine.cc View 1 chunk +0 lines, -70 lines 0 comments Download
A webrtc/test/mock_voice_engine.h View 1 2 3 1 chunk +322 lines, -0 lines 0 comments Download
M webrtc/test/webrtc_test_common.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/include/voe_rtp_rtcp.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
the sun
5 years, 1 month ago (2015-11-02 15:27:21 UTC) #2
tommi
lgtm
5 years, 1 month ago (2015-11-02 15:37:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402403008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402403008/20001
5 years, 1 month ago (2015-11-02 16:39:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1521)
5 years, 1 month ago (2015-11-02 16:43:52 UTC) #8
the sun
Committed patchset #4 (id:60001) manually as 0ccae135562ac180da053fcecda91a0365621f14 (presubmit successful).
5 years, 1 month ago (2015-11-03 09:16:05 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 09:16:10 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0ccae135562ac180da053fcecda91a0365621f14
Cr-Commit-Position: refs/heads/master@{#10491}

Powered by Google App Engine
This is Rietveld 408576698