Issue 1401743002: Fix: RefCountInterface: Make AddRef() and Release() const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401743002: Fix: RefCountInterface: Make AddRef() and Release() const (Closed)

Created:
5 years, 2 months ago by magjed_webrtc

Modified:
5 years, 2 months ago

Reviewers:
tommi

CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Fix: RefCountInterface: Make AddRef() and Release() const The landed CL contained some unwanted changes. TBR=tommi Committed: https://crrev.com/fc950848e39c5627c9af3e3a44e5177843b03d09 Cr-Commit-Position: refs/heads/master@{#10255}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	talk/app/webrtc/dtmfsender_unittest.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	webrtc/base/refcount.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

magjed_webrtc

Committed patchset #1 (id:1) manually as fc950848e39c5627c9af3e3a44e5177843b03d09 (presubmit successful).

5 years, 2 months ago (2015-10-12 14:10:54 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-12 14:11:00 UTC) #3

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fc950848e39c5627c9af3e3a44e5177843b03d09
Cr-Commit-Position: refs/heads/master@{#10255}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages