Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1401463003: Avoid data race in RtcpReceiver. (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoid data race in RtcpReceiver. See eg https://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/3930/steps/video_engine_tests/logs/stdio Also some cleanup, lock annotations. BUG= Committed: https://crrev.com/7dc39f331a161a24a4d4c6aac7cfb6850f43fb56 Cr-Commit-Position: refs/heads/master@{#10266}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -60 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 2 chunks +63 lines, -33 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 21 chunks +5 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
sprang_webrtc
5 years, 2 months ago (2015-10-09 08:29:39 UTC) #2
pbos-webrtc
lgtm woo https://codereview.webrtc.org/1401463003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right): https://codereview.webrtc.org/1401463003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h#newcode138 webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:138: git cl format
5 years, 2 months ago (2015-10-09 09:50:52 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1401463003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right): https://codereview.webrtc.org/1401463003/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h#newcode138 webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:138: On 2015/10/09 09:50:52, pbos-webrtc wrote: > git cl format ...
5 years, 2 months ago (2015-10-09 11:18:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401463003/20001
5 years, 2 months ago (2015-10-09 11:19:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1173)
5 years, 2 months ago (2015-10-09 11:24:23 UTC) #9
sprang_webrtc
+stefan as owner.
5 years, 2 months ago (2015-10-09 12:06:52 UTC) #11
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-13 15:00:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401463003/20001
5 years, 2 months ago (2015-10-13 15:02:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 16:17:54 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 16:18:04 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7dc39f331a161a24a4d4c6aac7cfb6850f43fb56
Cr-Commit-Position: refs/heads/master@{#10266}

Powered by Google App Engine
This is Rietveld 408576698