Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1401023003: Make VideoCapturerAndroid work on SDK level 16 (Closed)

Created:
5 years, 2 months ago by perkj_webrtc
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid, only you SurfaceViewHelper when capturing to textures. SurfaceViewHelper requires EGL14 that was added in API level 17. Since the SurfaceViewHelper is only neeed when we capture to textures, this cl change back to not use it when we are capturing to byte buffers. Also, thread.quitsafely was added in level 18. Instead a new ThreadUtil method has been added for this. BUG=b/24782220 TEST = run ninja -C out/Debug libjingle_peerconnection_android_unittest && CHECKOUT_SOURCE_ROOT=`pwd` build/android/adb_install_apk.py --debug out/Debug/apks/libjingle_peerconnection_android_unittest.apk && ./third_party/android_tools/sdk/platform-tools/adb shell am instrument -w -e class org.webrtc.VideoCapturerAndroidTest org.webrtc.test/android.test.InstrumentationTestRunner on a device running Android 4.1 (I tried Nexus 7, the first version) Committed: https://crrev.com/73f44f6481b2a767c80693224ec3b334c26bc4e7 Cr-Commit-Position: refs/heads/master@{#10265}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -13 lines) Patch
M talk/app/webrtc/androidtests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 9 chunks +37 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java View 1 1 chunk +14 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 9 chunks +39 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
please?
5 years, 2 months ago (2015-10-11 16:31:46 UTC) #2
magjed_webrtc
lgtm if this is a temporary fix
5 years, 2 months ago (2015-10-13 14:16:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401023003/20001
5 years, 2 months ago (2015-10-13 14:32:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 15:15:09 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 15:15:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73f44f6481b2a767c80693224ec3b334c26bc4e7
Cr-Commit-Position: refs/heads/master@{#10265}

Powered by Google App Engine
This is Rietveld 408576698