Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1400333002: Log Call {audio, video} stream deletions. (Closed)

Created:
5 years, 2 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
the sun, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Log Call {audio, video} stream deletions. BUG= R=solenberg@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/a2f30deea342896ee40cc4d90567f091efbe0fc9 Cr-Commit-Position: refs/heads/master@{#10286}

Patch Set 1 #

Patch Set 2 : move logging to ctor/dtor #

Total comments: 4

Patch Set 3 : compile #

Patch Set 4 : updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M webrtc/audio/audio_receive_stream.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M webrtc/call/call.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
pbos-webrtc
PTAL, this should make logs a bit easier to understand
5 years, 2 months ago (2015-10-14 10:01:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400333002/1
5 years, 2 months ago (2015-10-14 10:02:15 UTC) #3
pbos-webrtc
move logging to ctor/dtor
5 years, 2 months ago (2015-10-14 10:24:50 UTC) #4
pbos-webrtc
Moved logging to ctor/dtor, ptal +solenberg@ for webrtc/audio
5 years, 2 months ago (2015-10-14 10:25:37 UTC) #6
pbos-webrtc
compile
5 years, 2 months ago (2015-10-14 10:29:01 UTC) #7
stefan-webrtc
https://codereview.webrtc.org/1400333002/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/1400333002/diff/20001/webrtc/call/call.cc#newcode180 webrtc/call/call.cc:180: // logging to match others. Rewrite these comments. https://codereview.webrtc.org/1400333002/diff/20001/webrtc/video/video_send_stream.cc ...
5 years, 2 months ago (2015-10-14 10:30:16 UTC) #8
the sun
On 2015/10/14 10:30:16, stefan-webrtc (holmer) wrote: > https://codereview.webrtc.org/1400333002/diff/20001/webrtc/call/call.cc > File webrtc/call/call.cc (right): > > https://codereview.webrtc.org/1400333002/diff/20001/webrtc/call/call.cc#newcode180 ...
5 years, 2 months ago (2015-10-14 13:25:29 UTC) #9
pbos-webrtc
updated comment
5 years, 2 months ago (2015-10-15 10:21:39 UTC) #10
pbos-webrtc
PTAL https://codereview.webrtc.org/1400333002/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/1400333002/diff/20001/webrtc/call/call.cc#newcode180 webrtc/call/call.cc:180: // logging to match others. On 2015/10/14 10:30:16, ...
5 years, 2 months ago (2015-10-15 10:21:43 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400333002/60001
5 years, 2 months ago (2015-10-15 11:36:25 UTC) #13
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-15 11:38:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1400333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1400333002/60001
5 years, 2 months ago (2015-10-15 11:40:10 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-15 12:22:16 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 12:22:30 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a2f30deea342896ee40cc4d90567f091efbe0fc9
Cr-Commit-Position: refs/heads/master@{#10286}

Powered by Google App Engine
This is Rietveld 408576698