Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java

Issue 1399473003: Revert "Add option to print peer connection factory Java stack traces." (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java
diff --git a/talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java b/talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java
index 0460624aa7c1eb36ab0f41862d8da947d2f83d7a..6bc8189cd85e80c5fb1987fb297b214ec1a68a0d 100644
--- a/talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java
+++ b/talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java
@@ -148,21 +148,19 @@ public class PeerConnectionFactory {
nativeThreadsCallbacks(nativeFactory);
}
- private static void printStackTrace(Thread thread, String threadName) {
- if (thread != null) {
- StackTraceElement[] stackTraces = thread.getStackTrace();
- if (stackTraces.length > 0) {
- Logging.d(TAG, threadName + " stacks trace:");
- for (StackTraceElement stackTrace : stackTraces) {
- Logging.d(TAG, stackTrace.toString());
- }
+ public static void printStackTraces() {
+ if (workerThread != null) {
+ Logging.d(TAG, "Worker thread stacks trace:");
+ for (StackTraceElement stackTrace : workerThread.getStackTrace()) {
+ Logging.d(TAG, stackTrace.toString());
+ }
+ }
+ if (signalingThread != null) {
+ Logging.d(TAG, "Signaling thread stacks trace:");
+ for (StackTraceElement stackTrace : signalingThread.getStackTrace()) {
+ Logging.d(TAG, stackTrace.toString());
}
}
- }
-
- public static void printStackTraces() {
- printStackTrace(workerThread, "Worker thread");
- printStackTrace(signalingThread, "Signaling thread");
}
private static void onWorkerThreadReady() {
« no previous file with comments | « talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698