Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1398793005: Add new Android camera events. (Closed)

Created:
5 years, 2 months ago by AlexG
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add new Android camera events. Add events to track when camera is requested to open, when first camera frame is available and when camera is closed. BUG=b/24271359 R=perkj@webrtc.org Committed: https://crrev.com/9781152e043e35e2f676ddcf5de079c9548f3b37 Cr-Commit-Position: refs/heads/master@{#10306}

Patch Set 1 #

Patch Set 2 : Add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -18 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 1 chunk +9 lines, -0 lines 0 comments Download
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 1 2 chunks +48 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 11 chunks +38 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
AlexG
PTAL
5 years, 2 months ago (2015-10-14 23:08:30 UTC) #2
perkj_webrtc
Please add simple test for this in VideoCapturerAndrdoidTest to make sure we don't break this ...
5 years, 2 months ago (2015-10-16 09:03:01 UTC) #3
AlexG
On 2015/10/16 09:03:01, perkj1 wrote: > Please add simple test for this in VideoCapturerAndrdoidTest to ...
5 years, 2 months ago (2015-10-16 19:11:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398793005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398793005/20001
5 years, 2 months ago (2015-10-16 19:12:46 UTC) #6
AlexG
Committed patchset #2 (id:20001) manually as 9781152e043e35e2f676ddcf5de079c9548f3b37 (presubmit successful).
5 years, 2 months ago (2015-10-16 20:10:28 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 20:10:28 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9781152e043e35e2f676ddcf5de079c9548f3b37
Cr-Commit-Position: refs/heads/master@{#10306}

Powered by Google App Engine
This is Rietveld 408576698