Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398443007: Pause/resume pacer from Call instead of via SendStreams. (Closed)

Created:
5 years, 2 months ago by stefan-webrtc
Modified:
5 years, 2 months ago
Reviewers:
pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Pause/resume pacer from Call instead of via SendStreams. BUG=webrtc:5073 Committed: https://crrev.com/457a61db616f17be54b32bc7d8bb781d53396f69 Cr-Commit-Position: refs/heads/master@{#10271}

Patch Set 1 #

Patch Set 2 : Remove call from vie encoder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M webrtc/call/call.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
stefan-webrtc
5 years, 2 months ago (2015-10-14 09:12:12 UTC) #2
pbos-webrtc
On 2015/10/14 09:12:12, stefan-webrtc (holmer) wrote: Remove the corresponding pacer call from ViEEncoder please.
5 years, 2 months ago (2015-10-14 09:13:42 UTC) #3
stefan-webrtc
Remove call from vie encoder
5 years, 2 months ago (2015-10-14 09:18:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398443007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398443007/20001
5 years, 2 months ago (2015-10-14 09:18:25 UTC) #6
stefan-webrtc
Done.
5 years, 2 months ago (2015-10-14 09:18:50 UTC) #7
pbos-webrtc
lgtm, thanks
5 years, 2 months ago (2015-10-14 09:19:19 UTC) #8
mflodman
LGTM
5 years, 2 months ago (2015-10-14 09:32:37 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 10:04:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398443007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398443007/20001
5 years, 2 months ago (2015-10-14 10:04:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 10:13:05 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 10:13:11 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/457a61db616f17be54b32bc7d8bb781d53396f69
Cr-Commit-Position: refs/heads/master@{#10271}

Powered by Google App Engine
This is Rietveld 408576698