Android: Add helper function to synchronously execute Callables on Handler

Android: Add helper function to synchronously execute Callables on Handler

TBR=hbos

Committed: https://crrev.com/e9e366875992baf60caf5baaec302e2f1de013b2
Cr-Commit-Position: refs/heads/master@{#10246}

[magjed_webrtc, 2015-10-12 07:14:41]

magjed@webrtc.org changed reviewers:
+ hbos@webrtc.org

[magjed_webrtc, 2015-10-12 07:15:26]

hbos - Please take a look. I need this helper function for an urgent bug, so I
will TBR, but please review when you have time.

[magjed_webrtc, 2015-10-12 07:16:04]

Committed patchset #1 (id:1) manually as
e9e366875992baf60caf5baaec302e2f1de013b2 (presubmit successful).

[commit-bot: I haz the power, 2015-10-12 07:16:10]

Patchset 1 (id:??) landed as
https://crrev.com/e9e366875992baf60caf5baaec302e2f1de013b2
Cr-Commit-Position: refs/heads/master@{#10246}

[hbos, 2015-10-12 08:18:00]

lgtm

[hbos, 2015-10-12 08:20:19]

https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java (right):

https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java:121: throw new
RuntimeException("Callable threw exception: " + e);
On second thought, this will catch InterruptedExceptions too and wrap them in
RuntimeExceptions, meaning it will not get caught and it will crash.

You need to catch InterruptedException and rethrow it without wrapping
separately. Fix in a follow-up CL.

[magjed_webrtc, 2015-10-12 14:29:01]

https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
File talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java (right):

https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java:121: throw new
RuntimeException("Callable threw exception: " + e);
On 2015/10/12 08:20:19, hbos wrote:
> On second thought, this will catch InterruptedExceptions too and wrap them in
> RuntimeExceptions, meaning it will not get caught and it will crash.
> 
> You need to catch InterruptedException and rethrow it without wrapping
> separately. Fix in a follow-up CL.

Actually, this is correct. The InterruptedException has nothing to do with the
callable. InterruptedException may be thrown by barrier.await() and that is
handled in 'awaitUninterruptibly(barrier)'.

[hbos, 2015-10-12 15:12:07]

On 2015/10/12 14:29:01, magjed_webrtc wrote:
>
https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
> File talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java (right):
> 
>
https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
> talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java:121: throw new
> RuntimeException("Callable threw exception: " + e);
> On 2015/10/12 08:20:19, hbos wrote:
> > On second thought, this will catch InterruptedExceptions too and wrap them
in
> > RuntimeExceptions, meaning it will not get caught and it will crash.
> > 
> > You need to catch InterruptedException and rethrow it without wrapping
> > separately. Fix in a follow-up CL.
> 
> Actually, this is correct. The InterruptedException has nothing to do with the
> callable. InterruptedException may be thrown by barrier.await() and that is
> handled in 'awaitUninterruptibly(barrier)'.

http://i.imgur.com/wNP8CCQ.png
Callable.call() is allowed to throw any Exception, including
InterruptedException. You should not assume the implementation handles them.

[hbos, 2015-10-12 15:17:17]

On 2015/10/12 15:12:07, hbos wrote:
> On 2015/10/12 14:29:01, magjed_webrtc wrote:
> >
>
https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
> > File talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java (right):
> > 
> >
>
https://codereview.webrtc.org/1398283002/diff/1/talk/app/webrtc/java/android/...
> > talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java:121: throw new
> > RuntimeException("Callable threw exception: " + e);
> > On 2015/10/12 08:20:19, hbos wrote:
> > > On second thought, this will catch InterruptedExceptions too and wrap them
> in
> > > RuntimeExceptions, meaning it will not get caught and it will crash.
> > > 
> > > You need to catch InterruptedException and rethrow it without wrapping
> > > separately. Fix in a follow-up CL.
> > 
> > Actually, this is correct. The InterruptedException has nothing to do with
the
> > callable. InterruptedException may be thrown by barrier.await() and that is
> > handled in 'awaitUninterruptibly(barrier)'.
> 
> http://i.imgur.com/wNP8CCQ.png
> Callable.call() is allowed to throw any Exception, including
> InterruptedException. You should not assume the implementation handles them.

nvm, lgtm again