Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: talk/app/webrtc/peerconnection.h

Issue 1397973002: Merging BaseSession code into WebRtcSession. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Merging with master (MediaStreamSignaling removal affected WebRtcSession). Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/peerconnection.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 VideoTrackInterface* video_track); 202 VideoTrackInterface* video_track);
203 203
204 // Implements IceObserver 204 // Implements IceObserver
205 void OnIceConnectionChange(IceConnectionState new_state) override; 205 void OnIceConnectionChange(IceConnectionState new_state) override;
206 void OnIceGatheringChange(IceGatheringState new_state) override; 206 void OnIceGatheringChange(IceGatheringState new_state) override;
207 void OnIceCandidate(const IceCandidateInterface* candidate) override; 207 void OnIceCandidate(const IceCandidateInterface* candidate) override;
208 void OnIceComplete() override; 208 void OnIceComplete() override;
209 void OnIceConnectionReceivingChange(bool receiving) override; 209 void OnIceConnectionReceivingChange(bool receiving) override;
210 210
211 // Signals from WebRtcSession. 211 // Signals from WebRtcSession.
212 void OnSessionStateChange(cricket::BaseSession* session, 212 void OnSessionStateChange(WebRtcSession* session, WebRtcSession::State state);
213 cricket::BaseSession::State state);
214 void ChangeSignalingState(SignalingState signaling_state); 213 void ChangeSignalingState(SignalingState signaling_state);
215 214
216 rtc::Thread* signaling_thread() const { 215 rtc::Thread* signaling_thread() const {
217 return factory_->signaling_thread(); 216 return factory_->signaling_thread();
218 } 217 }
219 218
220 void PostSetSessionDescriptionFailure(SetSessionDescriptionObserver* observer, 219 void PostSetSessionDescriptionFailure(SetSessionDescriptionObserver* observer,
221 const std::string& error); 220 const std::string& error);
222 void PostCreateSessionDescriptionFailure( 221 void PostCreateSessionDescriptionFailure(
223 CreateSessionDescriptionObserver* observer, 222 CreateSessionDescriptionObserver* observer,
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 // because its destruction fires signals (such as VoiceChannelDestroyed) 388 // because its destruction fires signals (such as VoiceChannelDestroyed)
390 // which will trigger some final actions in PeerConnection... 389 // which will trigger some final actions in PeerConnection...
391 rtc::scoped_ptr<WebRtcSession> session_; 390 rtc::scoped_ptr<WebRtcSession> session_;
392 // ... But stats_ depends on session_ so it should be destroyed even earlier. 391 // ... But stats_ depends on session_ so it should be destroyed even earlier.
393 rtc::scoped_ptr<StatsCollector> stats_; 392 rtc::scoped_ptr<StatsCollector> stats_;
394 }; 393 };
395 394
396 } // namespace webrtc 395 } // namespace webrtc
397 396
398 #endif // TALK_APP_WEBRTC_PEERCONNECTION_H_ 397 #endif // TALK_APP_WEBRTC_PEERCONNECTION_H_
OLDNEW
« no previous file with comments | « no previous file | talk/app/webrtc/peerconnection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698