Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: talk/media/base/mediachannel.h

Issue 1397773002: Change SetOutputScaling to set a single level, not left/right levels. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/base/mediachannel.h
diff --git a/talk/media/base/mediachannel.h b/talk/media/base/mediachannel.h
index bf06e236861ed01e8d6ba63b3735e2cb629e3ca5..4bd9c5674a5f3c1ebedcfb289a7506fcb67b2ed1 100644
--- a/talk/media/base/mediachannel.h
+++ b/talk/media/base/mediachannel.h
@@ -1086,8 +1086,8 @@ class VoiceMediaChannel : public MediaChannel {
virtual void SetTypingDetectionParameters(int time_window,
int cost_per_typing, int reporting_threshold, int penalty_decay,
int type_event_delay) = 0;
- // Set left and right scale for speaker output volume of the specified ssrc.
- virtual bool SetOutputScaling(uint32_t ssrc, double left, double right) = 0;
+ // Set scaling for speaker output volume of the specified ssrc.
+ virtual bool SetOutputScaling(uint32_t ssrc, double volume) = 0;
pthatcher1 2015/10/08 18:37:49 Can you rename this SetOutputVolume?
the sun 2015/10/09 08:01:21 Done.
// Returns if the telephone-event has been negotiated.
virtual bool CanInsertDtmf() { return false; }
// Send and/or play a DTMF |event| according to the |flags|.

Powered by Google App Engine
This is Rietveld 408576698