Change SetOutputScaling to set a single level, not left/right levels.

Change SetOutputScaling to set a single level, not left/right levels.

BUG=webrtc:4690
Committed: https://crrev.com/4bac9c53da9988741d59753c2d789adb94de5e68
Cr-Commit-Position: refs/heads/master@{#10234}

[the sun, 2015-10-08 15:29:47]

solenberg@webrtc.org changed reviewers:
+ pthatcher@google.com

[pthatcher1, 2015-10-08 18:37:49]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-10-08 18:37:50]

lgtm

I'd prefer the name change, but it's not critical.

https://codereview.webrtc.org/1397773002/diff/1/talk/media/base/mediachannel.h
File talk/media/base/mediachannel.h (right):

https://codereview.webrtc.org/1397773002/diff/1/talk/media/base/mediachannel....
talk/media/base/mediachannel.h:1090: virtual bool SetOutputScaling(uint32_t
ssrc, double volume) = 0;
Can you rename this SetOutputVolume?

https://codereview.webrtc.org/1397773002/diff/1/talk/session/media/channel.h
File talk/session/media/channel.h (right):

https://codereview.webrtc.org/1397773002/diff/1/talk/session/media/channel.h#...
talk/session/media/channel.h:368: bool SetOutputScaling(uint32_t ssrc, double
volume);
Can this also (SetOutputVolume)?

[the sun, 2015-10-09 07:56:06]

solenberg@webrtc.org changed reviewers:
- pthatcher@google.com

[the sun, 2015-10-09 08:01:22]

https://codereview.webrtc.org/1397773002/diff/1/talk/media/base/mediachannel.h
File talk/media/base/mediachannel.h (right):

https://codereview.webrtc.org/1397773002/diff/1/talk/media/base/mediachannel....
talk/media/base/mediachannel.h:1090: virtual bool SetOutputScaling(uint32_t
ssrc, double volume) = 0;
On 2015/10/08 18:37:49, pthatcher1 wrote:
> Can you rename this SetOutputVolume?

Done.

https://codereview.webrtc.org/1397773002/diff/1/talk/session/media/channel.h
File talk/session/media/channel.h (right):

https://codereview.webrtc.org/1397773002/diff/1/talk/session/media/channel.h#...
talk/session/media/channel.h:368: bool SetOutputScaling(uint32_t ssrc, double
volume);
On 2015/10/08 18:37:50, pthatcher1 wrote:
> Can this also (SetOutputVolume)?

Done.

[the sun, 2015-10-09 08:02:02]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-10-09 08:02:03]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1397773002/#ps20001 (title:
"rebase+rename")

[commit-bot: I haz the power, 2015-10-09 08:02:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397773002/20001

[commit-bot: I haz the power, 2015-10-09 09:32:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-09 09:33:07]

Patchset 2 (id:??) landed as
https://crrev.com/4bac9c53da9988741d59753c2d789adb94de5e68
Cr-Commit-Position: refs/heads/master@{#10234}